Subject: Re: [ewg] [PATCH 14/14] nes: kernel build infrastructure

From: Roland Dreier <[email-masked]>
Date: Thu, 09 Aug 2007 10:34:22 -0700

> +ifdef CONFIG_INFINIBAND_NES_DEBUG
 > +EXTRA_CFLAGS += -DNES_DEBUG
 > +endif

I would just use the CONFIG_INFINIBAND_NES_DEBUG symbol directly in
your code.

 > +EXTRA_CFLAGS += -DNES_MINICM

If you're defining this unconditionally, can you just get rid of all
the tests of this symbol?

 - R.