Subject: Re: [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver

From: Roland Dreier <[email-masked]>
Date: Fri, 21 Nov 2008 09:58:37 -0800

> > --- /dev/null
 > > +++ b/net/dcb/Kconfig
 > > @@ -0,0 +1,12 @@
 > > +config DCB
 > > +        tristate "Data Center Bridging support"

 > A help text would be nice to have.

Yes, agreed -- something giving a hint about what DCB is (per-priority
pause, BCN) and guidance for the user that this should be enabled if
using DCB-capable NICs and switches.

 > > +
 > > +config DCBNL
 > > +	bool "Data Center Bridging netlink interface support"
 > > +	depends on DCB
 > > +	default n
 > > +	---help---
 > > +	  This option turns on the netlink interface
 > > +	  (dcbnl) for Data Center Bridging capable devices.
 > > +
 > > +	  If unsure, say N.

Now that I look at this config, it looks rather strange.  When does is
ever make sense to enable DCB but not DCBNL?  How else does one
configure all the DCB parameters except by running dcbd in userspace?
Should there even be a separate DCBNL option at all?

 - R.