Subject: Re: [PATCH 2/3] cnic: Add CNIC driver.

From: Roland Dreier <[email-masked]>
Date: Fri, 23 May 2008 13:14:54 -0700

> +		/* Tell compiler that status_blk fields can change. */
 > +		barrier();
 > +		if (status_idx != sblk->status_idx) {

Is a compiler barrier sufficient here?  It seems an out-of-order CPU
could still mess things up, so an rmb() or smp_rmb() would be required.