Subject: Re: [PATCH RFC 01/10] mlx4_en: Include file

From: Roland Dreier <[email-masked]>
Date: Tue, 15 Jul 2008 12:29:01 -0700

> +enum mlx4_en_state {
 > +	DEVICE_DOWN,
 > +	DEVICE_UP,
 > +	DEVICE_GOING_DOWN,
 > +	DEVICE_DISABLED
 > +};

I don't see any place that sets the state to anything other than UP or
DOWN.  Maybe it would be clearer to get rid of the enum and just have

	bool      device_up;

in your structure?