Subject: Re: [PATCH RFC 01/10] mlx4_en: Include file

From: Roland Dreier <[email-masked]>
Date: Tue, 15 Jul 2008 12:27:29 -0700

> +	MLX4_EN_FLAG_HIGH_DMA   = 1 << 2,
 > +	MLX4_EN_FLAG_FW_RUNNING = 1 << 3

I don't see anywhere that sets either of these flags.  The test of
HIGH_DMA seems strange:

 > +	if (mdev->mlx4_en_flags & MLX4_EN_FLAG_HIGH_DMA)
 > +		dev->features |= NETIF_F_HIGHDMA;

I think you can safely assume that an mlx4 device can DMA to any bus
address, and just set NETIF_F_HIGHDMA unconditionally.