Subject: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile.

From: Roland Dreier <[email-masked]>
Date: Sun, 25 May 2008 15:43:56 -0700

> +config INFINIBAND_QLGC_VNIC_DEBUG
 > +	bool "QLogic VNIC Verbose debugging"
 > +	depends on INFINIBAND_QLGC_VNIC
 > +	default n
 > +	---help---
 > +	  This option causes verbose debugging code to be compiled
 > +	  into the QLogic VNIC driver.  The output can be turned on via the
 > +	  vnic_debug module parameter.

I think I mentioned this before, but... if you default this option to
'n', then all distributions will build your module with the option off.
And if someone is having problems, they will be forced to rebuild their
kernel to get debug output, which is a heavy burden for most users.

Much better to do something like what I ended up doing for mthca, which
is to have the option on unless someone specifically enables
CONFIG_EMBEDDED and goes out of their way to disable it:

	config INFINIBAND_MTHCA_DEBUG
		bool "Verbose debugging output" if EMBEDDED
		depends on INFINIBAND_MTHCA
		default y
		---help---
		  This option causes debugging code to be compiled into the