Subject: Re: [PATCH 2/14] nes: device structures and defines

From: Roland Dreier <[email-masked]>
Date: Wed, 08 Aug 2007 09:18:31 -0700

> But there are indeed a few cases that look wrong.

yes...

 > arch/x86_64/kernel/pci-calgary.c:       writel(cpu_to_be32(val), target);

eg this almost certainly wants to be

	writel(swab32(val), target);

or something equivalent like

	__raw_writel(cpu_to_be32(val), target);
	/* plus some suffficent memory ordering */

 - R.