From: Pablo Neira Ayuso <pablo@netfilter•org>
To: Florian Westphal <fw@strlen•de>
Cc: Weiming Shi <bestswngs@gmail•com>,
"David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Phil Sutter <phil@nwl•cc>, Simon Horman <horms@kernel•org>,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
Xiang Mei <xmei5@asu•edu>
Subject: Re: [PATCH nf] netfilter: nf_tables: use RCU-safe list primitives for basechain hook list
Date: Fri, 10 Apr 2026 13:14:53 +0200 [thread overview]
Message-ID: <adjbrcTOL8MLjtfh@chamomile> (raw)
In-Reply-To: <adjRiG_Bp3WpRYOz@strlen.de>
On Fri, Apr 10, 2026 at 12:31:36PM +0200, Florian Westphal wrote:
> Weiming Shi <bestswngs@gmail•com> wrote:
[...]
> > Replace list_move() in nft_delchain_hook() with list_del_rcu() plus an
> > intermediate pointer array, followed by synchronize_rcu() before the
> > deleted hooks' list pointers are reused to link them into the
> > transaction's private list. In the error paths, put hooks back with
> > list_add_tail_rcu() which is safe for concurrent RCU readers (they
> > either continue to the original successor or see the list head and
> > terminate the walk).
>
> I don't understand the existing code.
I am working on an alternative fix.
next prev parent reply other threads:[~2026-04-10 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 10:13 [PATCH nf] netfilter: nf_tables: use RCU-safe list primitives for basechain hook list Weiming Shi
2026-04-10 10:31 ` Florian Westphal
2026-04-10 11:14 ` Pablo Neira Ayuso [this message]
2026-04-15 16:54 ` Pablo Neira Ayuso
2026-04-16 4:30 ` Xiang Mei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adjbrcTOL8MLjtfh@chamomile \
--to=pablo@netfilter$(echo .)org \
--cc=bestswngs@gmail$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=phil@nwl$(echo .)cc \
--cc=xmei5@asu$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox