From: Yury Norov <ynorov@nvidia•com>
To: Ping-Ke Shih <pkshih@realtek•com>
Cc: "Thomas Gleixner" <tglx@kernel•org>,
"Ingo Molnar" <mingo@redhat•com>,
"Borislav Petkov" <bp@alien8•de>,
"Dave Hansen" <dave.hansen@linux•intel.com>,
"x86@kernel•org" <x86@kernel•org>,
"H. Peter Anvin" <hpa@zytor•com>,
"Andy Lutomirski" <luto@kernel•org>,
"Peter Zijlstra" <peterz@infradead•org>,
"Jonathan Cameron" <jic23@kernel•org>,
"David Lechner" <dlechner@baylibre•com>,
"Nuno Sá" <nuno.sa@analog•com>,
"Andy Shevchenko" <andy@kernel•org>,
"Richard Cochran" <richardcochran@gmail•com>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Yury Norov" <yury.norov@gmail•com>,
"Rasmus Villemoes" <linux@rasmusvillemoes•dk>,
"Hans de Goede" <hansg@kernel•org>,
"Linus Walleij" <linusw@kernel•org>,
"Sakari Ailus" <sakari.ailus@linux•intel.com>,
"Salah Triki" <salah.triki@gmail•com>,
"Achim Gratz" <Achim.Gratz@stromeko•de>,
"Ben Collins" <bcollins@watter•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-iio@vger•kernel.org" <linux-iio@vger•kernel.org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-rtc@vger•kernel.org" <linux-rtc@vger•kernel.org>
Subject: Re: [PATCH 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()
Date: Mon, 20 Apr 2026 13:59:42 -0400 [thread overview]
Message-ID: <aeZpjhVL-a6QqNdX@yury> (raw)
In-Reply-To: <5fea4ea146404b55919037594ab85f1a@realtek.com>
On Mon, Apr 20, 2026 at 07:49:19AM +0000, Ping-Ke Shih wrote:
> Yury Norov <ynorov@nvidia•com> wrote:
> > --- a/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c
> > +++ b/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c
> > @@ -206,9 +206,9 @@ static void rtw8852bx_efuse_parsing_tssi(struct rtw89_dev *rtwdev,
> > static bool _decode_efuse_gain(u8 data, s8 *high, s8 *low)
> > {
> > if (high)
> > - *high = sign_extend32(FIELD_GET(GENMASK(7, 4), data), 3);
> > + *high = FIELD_GET_SIGNED(GENMASK(7, 4), data);
> > if (low)
> > - *low = sign_extend32(FIELD_GET(GENMASK(3, 0), data), 3);
> > + *low = FIELD_GET(GENMASK(3, 0), data);
>
> FIELD_GET_SIGNED()?
>
> >
> > return data != 0xff;
> > }
Ah sorry. Will fix in v2
next prev parent reply other threads:[~2026-04-20 17:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 17:36 [PATCH 0/9] bitfield: add FIELD_GET_SIGNED() Yury Norov
2026-04-17 17:36 ` [PATCH 1/9] " Yury Norov
2026-04-17 18:12 ` Andy Shevchenko
2026-04-17 19:43 ` David Laight
2026-04-17 21:09 ` Yury Norov
2026-04-20 8:43 ` Johannes Berg
2026-04-24 14:50 ` David Laight
2026-04-24 16:35 ` Yury Norov
2026-04-24 21:37 ` David Laight
2026-04-27 8:29 ` Johannes Berg
2026-04-27 9:42 ` David Laight
2026-04-20 11:19 ` Peter Zijlstra
2026-04-20 17:54 ` Yury Norov
2026-04-21 9:27 ` David Laight
2026-04-17 17:36 ` [PATCH 2/9] x86/extable: switch to using FIELD_GET_SIGNED() Yury Norov
2026-04-20 11:24 ` Peter Zijlstra
2026-04-20 17:18 ` Yury Norov
2026-04-20 22:00 ` David Laight
2026-04-17 17:36 ` [PATCH 3/9] iio: intel_dc_ti_adc: " Yury Norov
2026-04-19 13:18 ` Jonathan Cameron
2026-04-17 17:36 ` [PATCH 4/9] iio: magnetometer: yas530: " Yury Norov
2026-04-19 13:20 ` Jonathan Cameron
2026-04-19 20:11 ` Linus Walleij
2026-04-17 17:36 ` [PATCH 5/9] iio: pressure: bmp280: " Yury Norov
2026-04-19 13:21 ` Jonathan Cameron
2026-04-17 17:36 ` [PATCH 6/9] iio: mcp9600: " Yury Norov
2026-04-19 13:21 ` Jonathan Cameron
2026-04-17 17:36 ` [PATCH 7/9] wifi: rtw89: " Yury Norov
2026-04-20 7:49 ` Ping-Ke Shih
2026-04-20 17:59 ` Yury Norov [this message]
2026-04-17 17:36 ` [PATCH 8/9] rtc: rv3032: " Yury Norov
2026-04-17 17:36 ` [PATCH 9/9] ptp: " Yury Norov
2026-04-17 18:23 ` [PATCH 0/9] bitfield: add FIELD_GET_SIGNED() Andy Shevchenko
2026-04-17 19:21 ` Yury Norov
2026-04-24 12:09 ` Jonathan Cameron
2026-04-24 15:50 ` Yury Norov
2026-04-24 17:10 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeZpjhVL-a6QqNdX@yury \
--to=ynorov@nvidia$(echo .)com \
--cc=Achim.Gratz@stromeko$(echo .)de \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andy@kernel$(echo .)org \
--cc=bcollins@watter$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=dlechner@baylibre$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hansg@kernel$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=jic23@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linusw@kernel$(echo .)org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=luto@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nuno.sa@analog$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=pkshih@realtek$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=sakari.ailus@linux$(echo .)intel.com \
--cc=salah.triki@gmail$(echo .)com \
--cc=tglx@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yury.norov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox