Subject: Re: [PATCH] net: ethtool: fix missing closing paren in rings_reply_size()

From: Breno Leitao <[email-masked]>
Date: Fri, 8 May 2026 02:33:28 -0700

On Fri, May 08, 2026 at 03:14:02PM +0800, Tao Cui wrote:
> sizeof(u32) on the _RINGS_CQE_SIZE line is missing its closing
> parenthesis, causing nla_total_size() to absorb the subsequent
> _TX_PUSH and _RX_PUSH entries. The resulting size estimate
> happens to be numerically identical due to NLA alignment, but
> the nesting is wrong and misleading.
> 
> Signed-off-by: Tao Cui <[email-masked]>

Reviewed-by: Breno Leitao <[email-masked]>

Even thought the resulting size is identical, I am wondering if you
should add the Fixes: here. (or target net-next instead).

I think this is a net material, which will require a Fixes: tag.