From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre•com>
To: Marc Kleine-Budde <mkl@pengutronix•de>
Cc: Michael Grzeschik <mgr@kernel•org>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
Paolo Abeni <pabeni@redhat•com>,
Vincent Mailhol <mailhol@kernel•org>,
Krzysztof Halasa <khc@pm•waw.pl>,
Johannes Berg <johannes@sipsolutions•net>,
Steffen Klassert <klassert@kernel•org>,
David Dillow <dave@thedillows•org>,
Ion Badulescu <ionut@badula•org>,
Mark Einon <mark.einon@gmail•com>,
Rasesh Mody <rmody@marvell•com>,
GR-Linux-NIC-Dev@marvell•com,
Manish Chopra <manishc@marvell•com>,
Potnuri Bharat Teja <bharat@chelsio•com>,
Denis Kirjanov <kirjanov@gmail•com>,
Jijie Shao <shaojijie@huawei•com>,
Jian Shen <shenjian15@huawei•com>,
Cai Huoqing <cai.huoqing@linux•dev>,
Fan Gong <gongfan1@huawei•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>,
Tariq Toukan <tariqt@nvidia•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Leon Romanovsky <leon@kernel•org>,
Mark Bloch <mbloch@nvidia•com>, Ido Schimmel <idosch@nvidia•com>,
Petr Machata <petrm@nvidia•com>, Yibo Dong <dong100@mucse•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
nic_swsd@realtek•com, Jiri Pirko <jiri@resnulli•us>,
Francois Romieu <romieu@fr•zoreil.com>,
Daniele Venzano <venza@brownhat•org>,
Samuel Chessman <chessman@tux•org>,
Jiawen Wu <jiawenwu@trustnetic•com>,
Mengyuan Lou <mengyuanlou@net-swift•com>,
Kevin Curtis <kevin.curtis@farsite•co.uk>,
Arend van Spriel <arend.vanspriel@broadcom•com>,
Stanislav Yakovlev <stas.yakovlev@gmail•com>,
Richard Cochran <richardcochran@gmail•com>,
Kees Cook <kees@kernel•org>,
Aleksandr Loktionov <aleksandr.loktionov@intel•com>,
Thomas Gleixner <tglx@kernel•org>,
Jacob Keller <jacob.e.keller@intel•com>,
Thomas Fourier <fourier.thomas@gmail•com>,
Ingo Molnar <mingo@kernel•org>,
Kory Maincent <kory.maincent@bootlin•com>,
Zilin Guan <zilin@seu•edu.cn>,
Vadim Fedorenko <vadim.fedorenko@linux•dev>,
Marco Crivellari <marco.crivellari@suse•com>,
Bjorn Helgaas <bhelgaas@google•com>,
David Arinzon <darinzon@amazon•com>,
Yeounsu Moon <yyyynoom@gmail•com>,
Denis Benato <benato.denis96@gmail•com>,
Yonglong Liu <liuyonglong@huawei•com>,
Andy Shevchenko <andriy.shevchenko@intel•com>,
Randy Dunlap <rdunlap@infradead•org>,
Yicong Hui <yiconghui@gmail•com>,
MD Danish Anwar <danishanwar@ti•com>,
Nathan Chancellor <nathan@kernel•org>,
Ethan Nelson-Moore <enelsonmoore@gmail•com>,
Larysa Zaremba <larysa.zaremba@intel•com>,
Ian Lin <ian.lin@infineon•com>,
Colin Ian King <colin.i.king@gmail•com>,
Double Lo <double.lo@cypress•com>,
Markus Schneider-Pargmann <msp@baylibre•com>,
Simon Horman <horms@kernel•org>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-can@vger•kernel.org, linux-parisc@vger•kernel.org,
intel-wired-lan@lists•osuosl.org, linux-rdma@vger•kernel.org,
oss-drivers@corigine•com, linux-wireless@vger•kernel.org,
brcm80211@lists•linux.dev, brcm80211-dev-list.pdl@broadcom•com
Subject: Re: [PATCH net-next v2 1/2] net: Consistently define pci_device_ids using named initializers
Date: Thu, 7 May 2026 16:23:43 +0200 [thread overview]
Message-ID: <afyfa4E4rNbkMYTk@monoceros> (raw)
In-Reply-To: <20260507-healthy-gainful-fox-500552-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]
Hello Marc,
On Thu, May 07, 2026 at 12:55:45PM +0200, Marc Kleine-Budde wrote:
> > + }, {
> > /* ASEM Dual CAN raw -new model */
> > - ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,
> > - ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS,
> > - 0, 0,
> > - (kernel_ulong_t)&plx_pci_card_info_asem_dual_can
> > + PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,
> > + ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS),
> > + .driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can,
> > },
> > - { 0,}
> > + { }
>
> Nitpick: can you convert the terminating entry to follow the same style
> as the rest of the driver:
>
> diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c
> index a03553b80a5d..d69ff0ccfd94 100644
> --- a/drivers/net/can/sja1000/plx_pci.c
> +++ b/drivers/net/can/sja1000/plx_pci.c
> @@ -353,8 +353,8 @@ static const struct pci_device_id plx_pci_tbl[] = {
> PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,
> ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS),
> .driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can,
> - },
> - { }
> + }, {
> + }
> };
> MODULE_DEVICE_TABLE(pci, plx_pci_tbl);
After the conversation in the v1 thread it was unclear to me if you
stand by your opinion, so I kept the format as it was. I interpret your
repetition of the nitpick as request to rework the can drivers for the
next revision (if that happens).
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-07 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 10:50 [PATCH net-next v2 0/2] Rework pci_device_id initialisation Uwe Kleine-König (The Capable Hub)
2026-05-07 10:50 ` [PATCH net-next v2 1/2] net: Consistently define pci_device_ids using named initializers Uwe Kleine-König (The Capable Hub)
2026-05-07 10:55 ` Marc Kleine-Budde
2026-05-07 14:23 ` Uwe Kleine-König (The Capable Hub) [this message]
2026-05-07 14:48 ` Marc Kleine-Budde
2026-05-07 10:50 ` [PATCH net-next v2 2/2] net: nfp: Drop PCI class entries with .class_mask = 0 Uwe Kleine-König (The Capable Hub)
2026-05-07 11:11 ` Loktionov, Aleksandr
2026-05-08 22:34 ` [PATCH net-next v2 0/2] Rework pci_device_id initialisation Jakub Kicinski
2026-05-09 6:42 ` Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afyfa4E4rNbkMYTk@monoceros \
--to=u.kleine-koenig@baylibre$(echo .)com \
--cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
--cc=aleksandr.loktionov@intel$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andriy.shevchenko@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=arend.vanspriel@broadcom$(echo .)com \
--cc=benato.denis96@gmail$(echo .)com \
--cc=bharat@chelsio$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=brcm80211-dev-list.pdl@broadcom$(echo .)com \
--cc=brcm80211@lists$(echo .)linux.dev \
--cc=cai.huoqing@linux$(echo .)dev \
--cc=chessman@tux$(echo .)org \
--cc=colin.i.king@gmail$(echo .)com \
--cc=danishanwar@ti$(echo .)com \
--cc=darinzon@amazon$(echo .)com \
--cc=dave@thedillows$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dong100@mucse$(echo .)com \
--cc=double.lo@cypress$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=enelsonmoore@gmail$(echo .)com \
--cc=fourier.thomas@gmail$(echo .)com \
--cc=gongfan1@huawei$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=ian.lin@infineon$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ionut@badula$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jiawenwu@trustnetic$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kees@kernel$(echo .)org \
--cc=kevin.curtis@farsite$(echo .)co.uk \
--cc=khc@pm$(echo .)waw.pl \
--cc=kirjanov@gmail$(echo .)com \
--cc=klassert@kernel$(echo .)org \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=larysa.zaremba@intel$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=liuyonglong@huawei$(echo .)com \
--cc=mailhol@kernel$(echo .)org \
--cc=manishc@marvell$(echo .)com \
--cc=marco.crivellari@suse$(echo .)com \
--cc=mark.einon@gmail$(echo .)com \
--cc=mbloch@nvidia$(echo .)com \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=mgr@kernel$(echo .)org \
--cc=mingo@kernel$(echo .)org \
--cc=mkl@pengutronix$(echo .)de \
--cc=msp@baylibre$(echo .)com \
--cc=nathan@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nic_swsd@realtek$(echo .)com \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=richardcochran@gmail$(echo .)com \
--cc=rmody@marvell$(echo .)com \
--cc=romieu@fr$(echo .)zoreil.com \
--cc=saeedm@nvidia$(echo .)com \
--cc=shaojijie@huawei$(echo .)com \
--cc=shenjian15@huawei$(echo .)com \
--cc=stas.yakovlev@gmail$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=tglx@kernel$(echo .)org \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=venza@brownhat$(echo .)org \
--cc=yiconghui@gmail$(echo .)com \
--cc=yyyynoom@gmail$(echo .)com \
--cc=zilin@seu$(echo .)edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox