From: David Gibson <david@gibson•dropbear.id.au>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Stefano Brivio <sbrivio@redhat•com>,
Fernando Fernandez Mancera <fmancera@suse•de>,
netdev@vger•kernel.org, yuhuang@redhat•com,
justin.iurman@gmail•com, horms@kernel•org, pabeni@redhat•com,
kuba@kernel•org, edumazet@google•com, davem@davemloft•net,
idosch@nvidia•com, dsahern@kernel•org,
Chris Adams <linux@cmadams•net>,
Beniamino Galvani <bgalvani@redhat•com>,
Thorsten Leemhuis <regressions@leemhuis•info>,
ihuguet@redhat•com, regressions@lists•linux.dev
Subject: Re: IPv6 address insertion order (was Re: [PATCH net v2] Revert "ipv6: preserve insertion order for same-scope addresses")
Date: Wed, 3 Jun 2026 11:56:37 +1000 [thread overview]
Message-ID: <ah-J1dXqU_sVAvZa@zatzit> (raw)
In-Reply-To: <da080bf1-fa2b-402a-a249-ee5ac004fb05@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
On Tue, Jun 02, 2026 at 02:46:22PM +0200, Andrew Lunn wrote:
> On Tue, Jun 02, 2026 at 04:44:19PM +1000, David Gibson wrote:
> > I get the impression there's a rough consensus that the best we can do
> > now is revert this change (already done), and make a new patch which
> > changes the insertion order to the "correct" one conditional on a new
> > flag.
> >
> > Stefano has enough other fires to fight, so I'm taking a look at
> > implementing that. Some initial thoughts, that I'm soliciting
> > feedback on:
>
> I've only been partially reading along...
>
> Are we talking about RTM_NEWADDR?
Yes.
> I've never worked on the code dealing with addresses. But in general,
> if you want to add new functionality to a netlink message, you add a
> new attribute to the message.
>
> https://elixir.bootlin.com/linux/v7.0.10/source/include/uapi/linux/if_addr.h#L26
Ah, good point, that's another option, and avoids using scarce flags
bits. It is a little bit odd, because generally the attributes are,
well, attributes, _of the new object_ being created (an address in
this case). Here we're adjusting where / how it is created, not
anything about the address itself.
Stil, definitely a better option that allocating a new flags bit.
Versus NLM_F_APPEND, I'll reply to Ido Schimmel.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-06-03 2:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 11:23 [PATCH net v2] Revert "ipv6: preserve insertion order for same-scope addresses" Fernando Fernandez Mancera
2026-05-29 11:41 ` Stefano Brivio
2026-05-29 11:45 ` Fernando Fernandez Mancera
2026-05-29 12:06 ` Chris Adams
2026-06-01 2:03 ` Matthieu Baerts
2026-06-01 13:35 ` Stefano Brivio
2026-06-01 14:01 ` Íñigo Huguet
2026-06-01 14:22 ` Thorsten Leemhuis
2026-06-03 5:46 ` Matthieu Baerts
2026-06-03 6:53 ` Íñigo Huguet
2026-06-03 7:17 ` Thorsten Leemhuis
2026-06-03 7:29 ` Fernando Fernandez Mancera
2026-06-03 8:00 ` Ido Schimmel
2026-06-03 8:06 ` Fernando Fernandez Mancera
2026-06-03 9:27 ` Matthieu Baerts
2026-06-03 8:02 ` David Gibson
2026-06-02 6:44 ` IPv6 address insertion order (was Re: [PATCH net v2] Revert "ipv6: preserve insertion order for same-scope addresses") David Gibson
2026-06-02 12:46 ` Andrew Lunn
2026-06-03 1:56 ` David Gibson [this message]
2026-06-02 13:21 ` Ido Schimmel
2026-06-03 2:34 ` David Gibson
2026-06-03 7:47 ` Ido Schimmel
2026-06-03 15:45 ` Stefano Brivio
2026-06-04 1:26 ` David Gibson
2026-06-04 18:39 ` Ido Schimmel
2026-06-04 22:55 ` Jakub Kicinski
2026-06-05 10:13 ` Stefano Brivio
2026-06-03 15:47 ` Nicolas Dichtel
2026-05-29 20:20 ` [PATCH net v2] Revert "ipv6: preserve insertion order for same-scope addresses" patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah-J1dXqU_sVAvZa@zatzit \
--to=david@gibson$(echo .)dropbear.id.au \
--cc=andrew@lunn$(echo .)ch \
--cc=bgalvani@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=fmancera@suse$(echo .)de \
--cc=horms@kernel$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=ihuguet@redhat$(echo .)com \
--cc=justin.iurman@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@cmadams$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=regressions@leemhuis$(echo .)info \
--cc=regressions@lists$(echo .)linux.dev \
--cc=sbrivio@redhat$(echo .)com \
--cc=yuhuang@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox