From: Breno Leitao <leitao@debian•org>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre•com>
Cc: Alexandra Winter <wintera@linux•ibm.com>,
Aswin Karuvally <aswin@linux•ibm.com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
Paolo Abeni <pabeni@redhat•com>,
Heiko Carstens <hca@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Alexander Gordeev <agordeev@linux•ibm.com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Sven Schnelle <svens@linux•ibm.com>,
linux-s390@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v1 net-next] s390/ism: Drop superflous zeros in pci_device_id array
Date: Fri, 22 May 2026 08:54:57 -0700 [thread overview]
Message-ID: <ahB7_10zHxM2HQWG@gmail.com> (raw)
In-Reply-To: <20260522153010.777081-2-u.kleine-koenig@baylibre.com>
On Fri, May 22, 2026 at 05:30:09PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Subject: [PATCH v1 net-next] s390/ism: Drop superflous zeros in pci_device_id array
Nit: s/superflous/superfluous/ ?
> The .driver_data member of the struct pci_device_id array were
> initialized by a list expressions to zero without making use of that
> value. In this case it's better to not specify a value at all and let
> the compiler fill in the zeros. Same for the list terminator that can
> better be completely empty.
>
> This patch doesn't introduce changes to the compiled array.
True. For a `static const` aggregate, omitted members are
zero-initialized per C99 6.7.8, so dropping the trailing `, 0` and
collapsing `{ 0, }` to `{ }` is a no-op at the object level.
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre•com>
Reviewed-by: Breno Leitao <leitao@debian•org>
next prev parent reply other threads:[~2026-05-22 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 15:30 [PATCH v1 net-next] s390/ism: Drop superflous zeros in pci_device_id array Uwe Kleine-König (The Capable Hub)
2026-05-22 15:54 ` Breno Leitao [this message]
2026-05-26 9:24 ` Alexandra Winter
2026-05-26 13:54 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahB7_10zHxM2HQWG@gmail.com \
--to=leitao@debian$(echo .)org \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=aswin@linux$(echo .)ibm.com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=svens@linux$(echo .)ibm.com \
--cc=u.kleine-koenig@baylibre$(echo .)com \
--cc=wintera@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox