From: Jiri Pirko <jiri@resnulli•us>
To: Tariq Toukan <tariqt@nvidia•com>
Cc: Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
Paolo Abeni <pabeni@redhat•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Jonathan Corbet <corbet@lwn•net>,
Shuah Khan <skhan@linuxfoundation•org>,
Simon Horman <horms@kernel•org>,
Saeed Mahameed <saeedm@nvidia•com>,
Leon Romanovsky <leon@kernel•org>,
Mark Bloch <mbloch@nvidia•com>,
"Borislav Petkov (AMD)" <bp@alien8•de>,
Andrew Morton <akpm@linux-foundation•org>,
Randy Dunlap <rdunlap@infradead•org>,
Thomas Gleixner <tglx@kernel•org>,
Petr Mladek <pmladek@suse•com>,
"Peter Zijlstra (Intel)" <peterz@infradead•org>,
Tejun Heo <tj@kernel•org>, Vlastimil Babka <vbabka@kernel•org>,
Feng Tang <feng.tang@linux•alibaba.com>,
Christian Brauner <brauner@kernel•org>,
Dave Hansen <dave.hansen@linux•intel.com>,
Dapeng Mi <dapeng1.mi@linux•intel.com>,
Kees Cook <kees@kernel•org>, Marco Elver <elver@google•com>,
Li RongQing <lirongqing@baidu•com>,
Eric Biggers <ebiggers@kernel•org>,
"Paul E. McKenney" <paulmck@kernel•org>,
linux-doc@vger•kernel.org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, linux-rdma@vger•kernel.org,
Gal Pressman <gal@nvidia•com>,
Dragos Tatulea <dtatulea@nvidia•com>,
Jiri Pirko <jiri@nvidia•com>, Shay Drori <shayd@nvidia•com>,
Moshe Shemesh <moshe@nvidia•com>
Subject: Re: [PATCH net-next 3/3] net/mlx5: Apply devlink default eswitch mode during init
Date: Tue, 26 May 2026 09:44:52 +0200 [thread overview]
Message-ID: <ahVPASuh4BZGOfx0@FV6GYCPJ69> (raw)
In-Reply-To: <20260521072434.362624-4-tariqt@nvidia.com>
Thu, May 21, 2026 at 09:24:34AM +0200, tariqt@nvidia•com wrote:
>From: Mark Bloch <mbloch@nvidia•com>
>
>Apply devlink default eswitch mode for mlx5 devices after successful
>device initialization while holding the devlink instance lock.
>
>At this point the devlink instance is registered and the mlx5 devlink
>operations are available, so the default eswitch mode can be applied to
>the matching PCI devlink handle.
>
>Signed-off-by: Mark Bloch <mbloch@nvidia•com>
>Reviewed-by: Shay Drori <shayd@nvidia•com>
>Reviewed-by: Moshe Shemesh <moshe@nvidia•com>
>Signed-off-by: Tariq Toukan <tariqt@nvidia•com>
>---
> drivers/net/ethernet/mellanox/mlx5/core/main.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
>diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
>index 0c6e4efe38c8..4528097f3d84 100644
>--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
>+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
>@@ -1391,6 +1391,21 @@ static void mlx5_unload(struct mlx5_core_dev *dev)
> mlx5_free_bfreg(dev, &dev->priv.bfreg);
> }
>
>+static void mlx5_devl_apply_default_esw_mode(struct mlx5_core_dev *dev)
>+{
>+ struct devlink *devlink = priv_to_devlink(dev);
>+ int err;
>+
>+ if (!MLX5_ESWITCH_MANAGER(dev))
>+ return;
>+
>+ devl_assert_locked(devlink);
>+ err = devl_apply_default_esw_mode(devlink);
>+ if (err)
>+ mlx5_core_warn(dev, "Couldn't apply default eswitch mode, err %d\n",
>+ err);
>+}
>+
> int mlx5_init_one_devl_locked(struct mlx5_core_dev *dev)
> {
> bool light_probe = mlx5_dev_is_lightweight(dev);
>@@ -1437,6 +1452,7 @@ int mlx5_init_one_devl_locked(struct mlx5_core_dev *dev)
> mlx5_core_err(dev, "mlx5_hwmon_dev_register failed with error code %d\n", err);
>
> mutex_unlock(&dev->intf_state_mutex);
>+ mlx5_devl_apply_default_esw_mode(dev);
I wonder how we can make this work for all. I mean, other driver would
silently ignore this command like arg, right? Any idea how to make all
drivers follow the arg from very beginning?
> return 0;
>
> err_register:
>@@ -1538,6 +1554,7 @@ int mlx5_load_one_devl_locked(struct mlx5_core_dev *dev, bool recovery)
> goto err_attach;
>
> mutex_unlock(&dev->intf_state_mutex);
>+ mlx5_devl_apply_default_esw_mode(dev);
> return 0;
>
> err_attach:
>--
>2.44.0
>
next prev parent reply other threads:[~2026-05-26 7:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 7:24 [PATCH net-next 0/3] devlink: Add boot-time eswitch mode defaults Tariq Toukan
2026-05-21 7:24 ` [PATCH net-next 1/3] net/mlx5: Clear FW reset-in-progress bit before reload Tariq Toukan
2026-05-21 7:24 ` [PATCH net-next 2/3] devlink: Add eswitch mode boot defaults Tariq Toukan
2026-05-21 7:24 ` [PATCH net-next 3/3] net/mlx5: Apply devlink default eswitch mode during init Tariq Toukan
2026-05-21 13:16 ` Mark Bloch
2026-05-21 13:41 ` Thomas Weißschuh
2026-05-21 21:02 ` Mark Bloch
2026-05-26 7:44 ` Jiri Pirko [this message]
2026-05-26 9:44 ` Mark Bloch
2026-05-26 14:07 ` Jiri Pirko
2026-05-26 15:03 ` Mark Bloch
2026-05-26 16:23 ` Jiri Pirko
2026-05-26 17:13 ` Mark Bloch
2026-05-27 5:14 ` Jiri Pirko
2026-05-27 7:03 ` Mark Bloch
2026-05-27 11:18 ` Jiri Pirko
2026-05-28 8:15 ` Mark Bloch
2026-05-29 10:25 ` Jiri Pirko
2026-05-25 19:42 ` [PATCH net-next 0/3] devlink: Add boot-time eswitch mode defaults Jakub Kicinski
2026-05-26 7:41 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahVPASuh4BZGOfx0@FV6GYCPJ69 \
--to=jiri@resnulli$(echo .)us \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=bp@alien8$(echo .)de \
--cc=brauner@kernel$(echo .)org \
--cc=corbet@lwn$(echo .)net \
--cc=dapeng1.mi@linux$(echo .)intel.com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=dtatulea@nvidia$(echo .)com \
--cc=ebiggers@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=elver@google$(echo .)com \
--cc=feng.tang@linux$(echo .)alibaba.com \
--cc=gal@nvidia$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jiri@nvidia$(echo .)com \
--cc=kees@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=lirongqing@baidu$(echo .)com \
--cc=mbloch@nvidia$(echo .)com \
--cc=moshe@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=saeedm@nvidia$(echo .)com \
--cc=shayd@nvidia$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=tariqt@nvidia$(echo .)com \
--cc=tglx@kernel$(echo .)org \
--cc=tj@kernel$(echo .)org \
--cc=vbabka@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox