From: Alan Maguire <alan.maguire@oracle•com>
To: Emanuele Giuseppe Esposito <eesposit@redhat•com>
Cc: kvm@vger•kernel.org,
Christian Borntraeger <borntraeger@de•ibm.com>,
Paolo Bonzini <pbonzini@redhat•com>,
Jim Mattson <jmattson@google•com>,
Alexander Viro <viro@zeniv•linux.org.uk>,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail•com>,
David Rientjes <rientjes@google•com>,
Jonathan Adams <jwadams@google•com>,
linux-doc@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-mips@vger•kernel.org,
kvm-ppc@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-s390@vger•kernel.org, linux-fsdevel@vger•kernel.org,
netdev@vger•kernel.org, brendanhiggins@google•com,
linux-kselftest@vger•kernel.org, kunit-dev@googlegroups•com
Subject: Re: [PATCH v3 3/7] kunit: tests for stats_fs API
Date: Wed, 27 May 2020 11:05:23 +0100 (BST) [thread overview]
Message-ID: <alpine.LRH.2.21.2005271054360.24819@localhost> (raw)
In-Reply-To: <20200526110318.69006-4-eesposit@redhat.com>
On Tue, 26 May 2020, Emanuele Giuseppe Esposito wrote:
> Add kunit tests to extensively test the stats_fs API functionality.
>
I've added in the kunit-related folks.
> In order to run them, the kernel .config must set CONFIG_KUNIT=y
> and a new .kunitconfig file must be created with CONFIG_STATS_FS=y
> and CONFIG_STATS_FS_TEST=y
>
It looks like CONFIG_STATS_FS is built-in, but it exports
much of the functionality you are testing. However could the
tests also be built as a module (i.e. make CONFIG_STATS_FS_TEST
a tristate variable)? To test this you'd need to specify
CONFIG_KUNIT=m and CONFIG_STATS_FS_TEST=m, and testing would
simply be a case of "modprobe"ing the stats fs module and collecting
results in /sys/kernel/debug/kunit/<module_name> (rather
than running kunit.py). Are you relying on unexported internals in
the the tests that would prevent building them as a module?
Thanks!
Alan
next prev parent reply other threads:[~2020-05-27 10:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 11:03 [PATCH v3 0/7] Statsfs: a new ram-based file system for Linux kernel statistics Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 1/7] stats_fs API: create, add and remove stats_fs sources and values Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 2/7] documentation for stats_fs Emanuele Giuseppe Esposito
2020-06-04 0:23 ` Randy Dunlap
2020-06-04 15:34 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 3/7] kunit: tests for stats_fs API Emanuele Giuseppe Esposito
2020-05-27 10:05 ` Alan Maguire [this message]
2020-05-27 13:26 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 4/7] stats_fs fs: virtual fs to show stats to the end-user Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 5/7] kvm_main: replace debugfs with stats_fs Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 6/7] [not for merge] kvm: example of stats_fs_value show function Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 7/7] [not for merge] netstats: example use of stats_fs API Emanuele Giuseppe Esposito
2020-05-26 14:16 ` Andrew Lunn
2020-05-26 15:45 ` Emanuele Giuseppe Esposito
2020-05-26 22:31 ` [PATCH v3 0/7] Statsfs: a new ram-based file system for Linux kernel statistics Jakub Kicinski
2020-05-27 13:14 ` Emanuele Giuseppe Esposito
2020-05-27 13:33 ` Andrew Lunn
2020-05-27 15:00 ` Paolo Bonzini
2020-05-27 20:23 ` Jakub Kicinski
2020-05-27 21:07 ` Paolo Bonzini
2020-05-27 21:27 ` Jakub Kicinski
2020-05-27 21:44 ` Paolo Bonzini
2020-05-27 22:21 ` David Ahern
2020-05-28 5:22 ` Paolo Bonzini
2020-05-27 21:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.2005271054360.24819@localhost \
--to=alan.maguire@oracle$(echo .)com \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=brendanhiggins@google$(echo .)com \
--cc=e.emanuelegiuseppe@gmail$(echo .)com \
--cc=eesposit@redhat$(echo .)com \
--cc=jmattson@google$(echo .)com \
--cc=jwadams@google$(echo .)com \
--cc=kunit-dev@googlegroups$(echo .)com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pbonzini@redhat$(echo .)com \
--cc=rientjes@google$(echo .)com \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox