public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: "Gustavo A. R. Silva" <gustavo@embeddedor•com>
To: "Switzer, David" <david.switzer@intel•com>,
	"Gustavo A. R. Silva" <gustavoars@kernel•org>,
	"Brandeburg, Jesse" <jesse.brandeburg@intel•com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel•com>,
	"David S. Miller" <davem@davemloft•net>,
	Jakub Kicinski <kuba@kernel•org>
Cc: Kees Cook <keescook@chromium•org>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
	"intel-wired-lan@lists•osuosl.org"
	<intel-wired-lan@lists•osuosl.org>,
	"linux-hardening@vger•kernel.org"
	<linux-hardening@vger•kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH][next] ixgbe: Fix out-bounds warning in ixgbe_host_interface_command()
Date: Tue, 11 May 2021 10:49:55 -0500	[thread overview]
Message-ID: <b0749fb9-ff4e-3237-e2f7-b97255545eb0@embeddedor.com> (raw)
In-Reply-To: <MW3PR11MB47483A28574E9F2C5517D3C5EB589@MW3PR11MB4748.namprd11.prod.outlook.com>

Hi all,

On 5/6/21 02:25, Switzer, David wrote:
> 
>> -----Original Message-----
>> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl•org> On Behalf Of
>> Gustavo A. R. Silva
>> Sent: Tuesday, April 13, 2021 12:04 PM
>> To: Brandeburg, Jesse <jesse.brandeburg@intel•com>; Nguyen, Anthony L
>> <anthony.l.nguyen@intel•com>; David S. Miller <davem@davemloft•net>; Jakub
>> Kicinski <kuba@kernel•org>
>> Cc: Kees Cook <keescook@chromium•org>; netdev@vger•kernel.org; linux-
>> kernel@vger•kernel.org; Gustavo A. R. Silva <gustavoars@kernel•org>; intel-
>> wired-lan@lists•osuosl.org; linux-hardening@vger•kernel.org
>> Subject: [Intel-wired-lan] [PATCH][next] ixgbe: Fix out-bounds warning in
>> ixgbe_host_interface_command()
>>
>> Replace union with a couple of pointers in order to fix the following out-of-
>> bounds warning:
>>
>>  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_common.o
>> drivers/net/ethernet/intel/ixgbe/ixgbe_common.c: In function
>> ‘ixgbe_host_interface_command’:
>> drivers/net/ethernet/intel/ixgbe/ixgbe_common.c:3729:13: warning: array
>> subscript 1 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-
>> bounds]
>> 3729 |   bp->u32arr[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG, bi);
>>      |   ~~~~~~~~~~^~~~
>> drivers/net/ethernet/intel/ixgbe/ixgbe_common.c:3682:7: note: while
>> referencing ‘u32arr’
>> 3682 |   u32 u32arr[1];
>>      |       ^~~~~~
>>
>> This helps with the ongoing efforts to globally enable -Warray-bounds.
>>
>> Link: https://github.com/KSPP/linux/issues/109
>> Co-developed-by: Kees Cook <keescook@chromium•org>
>> Signed-off-by: Kees Cook <keescook@chromium•org>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel•org>
>> ---
>> drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 16 +++++++---------
>> 1 file changed, 7 insertions(+), 9 deletions(-)
>>
> Tested-by: Dave Switzer <david.switzer@intel•com>

Thanks for this, Dave. :)

By the way, we are about to be able to globally enable -Warray-bounds and,
this is one of the last out-of-bounds warnings in linux-next.

Thanks
--
Gustavo

     prev parent reply	other threads:[~2021-05-11 15:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 19:03 [PATCH][next] ixgbe: Fix out-bounds warning in ixgbe_host_interface_command() Gustavo A. R. Silva
2021-05-06  7:25 ` [Intel-wired-lan] " Switzer, David
2021-05-11 15:49   ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0749fb9-ff4e-3237-e2f7-b97255545eb0@embeddedor.com \
    --to=gustavo@embeddedor$(echo .)com \
    --cc=anthony.l.nguyen@intel$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=david.switzer@intel$(echo .)com \
    --cc=gustavoars@kernel$(echo .)org \
    --cc=intel-wired-lan@lists$(echo .)osuosl.org \
    --cc=jesse.brandeburg@intel$(echo .)com \
    --cc=keescook@chromium$(echo .)org \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-hardening@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox