Subject: Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

From: "Chng, Jack Ping" <[email-masked]>
Date: Thu, 12 Dec 2019 15:25:17 +0800

Hi Dan,

On 11/12/2019 6:58 PM, Dan Carpenter wrote:

> This should just be sent to netdev.  I spotted a couple bugs.
>
> 1) enable/disable we flipped xgmac_set_xgmii_2500_speed()
> 2) retries wasn't reset in a couple places.
>
> I had a few tiny style nits as well but there is no reason to send it to
> staging.
>
> regards,
> dan carpenter

Thanks for the review and comments.
We will fix the bug and address the comments.

Best regards,
Chng Jack Ping