Subject: Re: [PATCH net-next 4/4] net: qualcomm: rmnet: Add support for GRO

From: Subash Abhinov Kasiviswanathan <[email-masked]>
Date: Wed, 25 Oct 2017 12:00:18 -0600

> You need to check return code and abort if memory could not be
> allocated.
> 
> There is a reason this helper has _init() prefix, it does not belong to
> _setup() since a _setup() is not expected to fail.
> 
> Please take a look at other gro_cells_init() callers, and you will
> notice that it is called from ndo_init()
> 
> You might have copied the only buggy caller (vxlan).
> 
> Tom, if you read me fix vxlan, thanks !

Hi Eric

Thanks for pointing this out. I'll change this in v2.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project