From: "Jiayuan Chen" <jiayuan.chen@linux•dev>
To: "Cong Wang" <xiyou.wangcong@gmail•com>
Cc: bpf@vger•kernel.org, mrpre@163•com,
"Alexei Starovoitov" <ast@kernel•org>,
"Daniel Borkmann" <daniel@iogearbox•net>,
"John Fastabend" <john.fastabend@gmail•com>,
"Andrii Nakryiko" <andrii@kernel•org>,
"Martin KaFai Lau" <martin.lau@linux•dev>,
"Eduard Zingerman" <eddyz87@gmail•com>,
"Song Liu" <song@kernel•org>,
"Yonghong Song" <yonghong.song@linux•dev>,
"KP Singh" <kpsingh@kernel•org>,
"Stanislav Fomichev" <sdf@fomichev•me>,
"Hao Luo" <haoluo@google•com>, "Jiri Olsa" <jolsa@kernel•org>,
"Jakub Sitnicki" <jakub@cloudflare•com>,
"Steven Rostedt" <rostedt@goodmis•org>,
"Masami Hiramatsu" <mhiramat@kernel•org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Simon Horman" <horms@kernel•org>,
"Jesper Dangaard Brouer" <hawk@kernel•org>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
linux-trace-kernel@vger•kernel.org
Subject: Re: [PATCH bpf-next v1] bpf, sockmap: Introduce tracing capability for sockmap
Date: Thu, 10 Apr 2025 01:19:09 +0000 [thread overview]
Message-ID: <b560604b7b97a58d13c60655747b30a5b9f27a4d@linux.dev> (raw)
In-Reply-To: <Z/aosJ3uvzTZTEXS@pop-os.localdomain>
April 10, 2025 at 01:04, "Cong Wang" <xiyou.wangcong@gmail•com> wrote:
>
> On Wed, Apr 09, 2025 at 06:29:33PM +0800, Jiayuan Chen wrote:
>
> >
> > Sockmap has the same high-performance forwarding capability as XDP, but
> >
> > operates at Layer 7.
> >
> >
> >
> > Introduce tracing capability for sockmap, similar to XDP, to trace the
> >
> > execution results of BPF programs without modifying the programs
> >
> > themselves, similar to the existing trace_xdp_redirect{_map}.
> >
> >
> >
> > It is crucial for debugging BPF programs, especially in production
> >
> > environments.
> >
> >
> >
> > Additionally, a header file was added to bpf_trace.h to automatically
> >
> > generate tracepoints.
> >
> >
> >
> > Test results:
> >
> > $ echo "1" > /sys/kernel/tracing/events/sockmap/enable
> >
> >
> >
> > skb:
> >
> > sockmap_redirect: sk=00000000d3266a8d, type=skb, family=2, protocol=6, \
> >
> > prog_id=73, length=256, action=PASS
> >
> >
> >
> > msg:
> >
> > sockmap_redirect: sk=00000000528c7614, type=msg, family=2, protocol=6, \
> >
> > prog_id=185, length=5, action=REDIRECT
> >
> >
> >
> > tls:
> >
> > sockmap_redirect: sk=00000000d04d2224, type=skb, family=2, protocol=6, \
> >
> > prog_id=143, length=35, action=PASS
> >
> >
> >
> > strparser:
> >
> > sockmap_skb_strp_parse: sk=00000000ecab0b30, family=2, protocol=6, \
> >
> > prog_id=170, size=5
> >
>
> Nice work!
>
> While you are on it, could we also trace skb->_sk_redir bits too? It is
>
> very useful to distinguish, at least, ingress from egress redirection.
>
> Thanks!
>
Thanks for your suggestion!
The skb->_sk_redir contains a lot of important information about
redirection, so it's definitely worth including.
next prev parent reply other threads:[~2025-04-10 1:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 10:29 [PATCH bpf-next v1] bpf, sockmap: Introduce tracing capability for sockmap Jiayuan Chen
2025-04-09 16:11 ` Steven Rostedt
2025-04-09 16:40 ` Jiayuan Chen
2025-04-09 17:04 ` Cong Wang
2025-04-10 1:19 ` Jiayuan Chen [this message]
2025-04-10 9:14 ` Jakub Sitnicki
2025-04-10 14:27 ` Jiayuan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b560604b7b97a58d13c60655747b30a5b9f27a4d@linux.dev \
--to=jiayuan.chen@linux$(echo .)dev \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eddyz87@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haoluo@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=jakub@cloudflare$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-trace-kernel@vger$(echo .)kernel.org \
--cc=martin.lau@linux$(echo .)dev \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=mrpre@163$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=sdf@fomichev$(echo .)me \
--cc=song@kernel$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
--cc=yonghong.song@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox