Subject: RE: [PATCH v2 1/6] Add ancillary bus support

From: "Saleem, Shiraz" <[email-masked]>
Date: Tue, 6 Oct 2020 17:45:41 +0000

> Subject: Re: [PATCH v2 1/6] Add ancillary bus support
> 
> On Mon, Oct 05, 2020 at 11:24:41AM -0700, Dave Ertman wrote:
> > Add support for the Ancillary Bus, ancillary_device and ancillary_driver.
> > It enables drivers to create an ancillary_device and bind an
> > ancillary_driver to it.
> >
> > The bus supports probe/remove shutdown and suspend/resume callbacks.
> > Each ancillary_device has a unique string based id; driver binds to an
> > ancillary_device based on this id through the bus.
> >
> > Co-developed-by: Kiran Patil <[email-masked]>
> > Signed-off-by: Kiran Patil <[email-masked]>
> > Co-developed-by: Ranjani Sridharan <[email-masked]>
> > Signed-off-by: Ranjani Sridharan <[email-masked]>
> > Co-developed-by: Fred Oh <[email-masked]>
> > Signed-off-by: Fred Oh <[email-masked]>
> > Reviewed-by: Pierre-Louis Bossart
> > <[email-masked]>
> > Reviewed-by: Shiraz Saleem <[email-masked]>
> > Reviewed-by: Parav Pandit <[email-masked]>
> > Reviewed-by: Dan Williams <[email-masked]>
> > Signed-off-by: Dave Ertman <[email-masked]>
> > ---
> 
> <...>
> 
> > +/**
> > + * __ancillary_driver_register - register a driver for ancillary bus
> > +devices
> > + * @ancildrv: ancillary_driver structure
> > + * @owner: owning module/driver
> > + */
> > +int __ancillary_driver_register(struct ancillary_driver *ancildrv,
> > +struct module *owner) {
> > +	if (WARN_ON(!ancildrv->probe) || WARN_ON(!ancildrv->remove) ||
> > +	    WARN_ON(!ancildrv->shutdown) || WARN_ON(!ancildrv->id_table))
> > +		return -EINVAL;
> 
> In our driver ->shutdown is empty, it will be best if ancillary bus will do "if (-
> >remove) ..->remove()" pattern.
> 
I prefer that too if its possible. We will look into it.