From: "Samudrala, Sridhar" <sridhar.samudrala@intel•com>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: Emil Tantilov <emil.s.tantilov@intel•com>,
<intel-wired-lan@lists•osuosl.org>, <shannon.nelson@amd•com>,
<simon.horman@corigine•com>, <leon@kernel•org>,
<decot@google•com>, <willemb@google•com>,
<jesse.brandeburg@intel•com>, <anthony.l.nguyen@intel•com>,
<davem@davemloft•net>, <edumazet@google•com>, <kuba@kernel•org>,
<pabeni@redhat•com>, <netdev@vger•kernel.org>,
"Singhai, Anjali" <anjali.singhai@intel•com>,
"Orr, Michael" <michael.orr@intel•com>
Subject: Re: [PATCH iwl-next v4 00/15] Introduce Intel IDPF driver
Date: Fri, 19 May 2023 10:36:00 -0700 [thread overview]
Message-ID: <bb44cf67-3b8c-7cc2-b48e-438cc9af5fdb@intel.com> (raw)
In-Reply-To: <20230519013710-mutt-send-email-mst@kernel.org>
On 5/18/2023 10:49 PM, Michael S. Tsirkin wrote:
> On Thu, May 18, 2023 at 04:26:24PM -0700, Samudrala, Sridhar wrote:
>>
>>
>> On 5/18/2023 10:10 AM, Michael S. Tsirkin wrote:
>>> On Thu, May 18, 2023 at 09:19:31AM -0700, Samudrala, Sridhar wrote:
>>>>
>>>>
>>>> On 5/11/2023 11:34 PM, Michael S. Tsirkin wrote:
>>>>> On Mon, May 08, 2023 at 12:43:11PM -0700, Emil Tantilov wrote:
>>>>>> This patch series introduces the Intel Infrastructure Data Path Function
>>>>>> (IDPF) driver. It is used for both physical and virtual functions. Except
>>>>>> for some of the device operations the rest of the functionality is the
>>>>>> same for both PF and VF. IDPF uses virtchnl version2 opcodes and
>>>>>> structures defined in the virtchnl2 header file which helps the driver
>>>>>> to learn the capabilities and register offsets from the device
>>>>>> Control Plane (CP) instead of assuming the default values.
>>>>>
>>>>> So, is this for merge in the next cycle? Should this be an RFC rather?
>>>>> It seems unlikely that the IDPF specification will be finalized by that
>>>>> time - how are you going to handle any specification changes?
>>>>
>>>> Yes. we would like this driver to be merged in the next cycle(6.5).
>>>> Based on the community feedback on v1 version of the driver, we removed all
>>>> references to OASIS standard and at this time this is an intel vendor
>>>> driver.
>>>>
>>>> Links to v1 and v2 discussion threads
>>>> https://lore.kernel.org/netdev/20230329140404.1647925-1-pavan.kumar.linga@intel.com/
>>>> https://lore.kernel.org/netdev/20230411011354.2619359-1-pavan.kumar.linga@intel.com/
>>>>
>>>> The v1->v2 change log reflects this update.
>>>> v1 --> v2: link [1]
>>>> * removed the OASIS reference in the commit message to make it clear
>>>> that this is an Intel vendor specific driver
>>>
>>> Yes this makes sense.
>>>
>>>
>>>> Any IDPF specification updates would be handled as part of the changes that
>>>> would be required to make this a common standards driver.
>>>
>>>
>>> So my question is, would it make sense to update Kconfig and module name
>>> to be "ipu" or if you prefer "intel-idpf" to make it clear this is
>>> currently an Intel vendor specific driver? And then when you make it a
>>> common standards driver rename it to idpf? The point being to help make
>>> sure users are not confused about whether they got a driver with
>>> or without IDPF updates. It's not critical I guess but seems like a good
>>> idea. WDYT?
>>
>> It would be more disruptive to change the name of the driver. We can update
>> the pci device table, module description and possibly driver version when we
>> are ready to make this a standard driver.
>> So we would prefer not changing the driver name.
>
> Kconfig entry and description too?
>
The current Kconfig entry has Intel references.
+config IDPF
+ tristate "Intel(R) Infrastructure Data Path Function Support"
+ depends on PCI_MSI
+ select DIMLIB
+ help
+ This driver supports Intel(R) Infrastructure Processing Unit (IPU)
+ devices.
It can be updated with Intel references removed when the spec becomes
standard and meets the community requirements.
next prev parent reply other threads:[~2023-05-19 17:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 19:43 [PATCH iwl-next v4 00/15] Introduce Intel IDPF driver Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 01/15] virtchnl: add virtchnl version 2 ops Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 02/15] idpf: add module register and probe functionality Emil Tantilov
2023-05-09 2:11 ` Yunsheng Lin
2023-05-08 19:43 ` [PATCH iwl-next v4 03/15] idpf: add controlq init and reset checks Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 04/15] idpf: add core init and interrupt request Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 05/15] idpf: add create vport and netdev configuration Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 06/15] idpf: continue expanding init task Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 07/15] idpf: configure resources for TX queues Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 08/15] idpf: configure resources for RX queues Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 09/15] idpf: initialize interrupts and enable vport Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 10/15] idpf: add splitq start_xmit Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 11/15] idpf: add TX splitq napi poll support Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 12/15] idpf: add RX " Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 13/15] idpf: add singleq start_xmit and napi poll Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 14/15] idpf: add ethtool callbacks Emil Tantilov
2023-05-08 19:43 ` [PATCH iwl-next v4 15/15] idpf: configure SRIOV and add other ndo_ops Emil Tantilov
2023-05-09 4:46 ` Bagas Sanjaya
2023-05-12 13:48 ` Tantilov, Emil S
2023-05-12 6:34 ` [PATCH iwl-next v4 00/15] Introduce Intel IDPF driver Michael S. Tsirkin
2023-05-18 16:19 ` Samudrala, Sridhar
2023-05-18 17:10 ` Michael S. Tsirkin
2023-05-18 23:26 ` Samudrala, Sridhar
2023-05-19 5:49 ` Michael S. Tsirkin
2023-05-19 17:36 ` Samudrala, Sridhar [this message]
2023-05-19 18:22 ` Andrew Lunn
2023-05-19 18:42 ` Willem de Bruijn
2023-05-21 9:21 ` Michael S. Tsirkin
2023-05-22 2:54 ` Samudrala, Sridhar
2023-05-22 20:08 ` Singhai, Anjali
2023-05-22 20:37 ` Andrew Lunn
2023-05-19 16:17 ` Shannon Nelson
2023-05-19 17:12 ` Willem de Bruijn
2023-05-22 19:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb44cf67-3b8c-7cc2-b48e-438cc9af5fdb@intel.com \
--to=sridhar.samudrala@intel$(echo .)com \
--cc=anjali.singhai@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=decot@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=emil.s.tantilov@intel$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=michael.orr@intel$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shannon.nelson@amd$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox