From: Jesse Brandeburg <jesse.brandeburg@intel•com>
To: Jakub Kicinski <kuba@kernel•org>, <anthony.l.nguyen@intel•com>
Cc: <shiraz.saleem@intel•com>, <netdev@vger•kernel.org>,
<intel-wired-lan@lists•osuosl.org>
Subject: Re: [PATCH] i40e: remove enum i40e_client_state
Date: Wed, 26 Jan 2022 11:53:29 -0800 [thread overview]
Message-ID: <bb6675f9-63ce-77a2-e4fe-76cc592e5f41@intel.com> (raw)
In-Reply-To: <20220126185544.2787111-1-kuba@kernel.org>
Thanks Jakub!
On 1/26/2022 10:55 AM, Jakub Kicinski wrote:
> It's not used.
minor nit, you didn't say if you wanted this to go to net or net-next or
add a Fixes: tag?
maybe:
Fixes: e3219ce6a775 ("i40e: Add support for client interface for IWARP
driver")
>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
for the patch itself, it looks fine to me, so if you spin this
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel•com>
> ---
> include/linux/net/intel/i40e_client.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/net/intel/i40e_client.h b/include/linux/net/intel/i40e_client.h
> index 6b3267b49755..ed42bd5f639f 100644
> --- a/include/linux/net/intel/i40e_client.h
> +++ b/include/linux/net/intel/i40e_client.h
> @@ -26,11 +26,6 @@ struct i40e_client_version {
> u8 rsvd;
> };
>
> -enum i40e_client_state {
> - __I40E_CLIENT_NULL,
> - __I40E_CLIENT_REGISTERED
> -};
> -
> enum i40e_client_instance_state {
> __I40E_CLIENT_INSTANCE_NONE,
> __I40E_CLIENT_INSTANCE_OPENED,
> @@ -190,11 +185,6 @@ struct i40e_client {
> const struct i40e_client_ops *ops; /* client ops provided by the client */
> };
>
> -static inline bool i40e_client_is_registered(struct i40e_client *client)
> -{
> - return test_bit(__I40E_CLIENT_REGISTERED, &client->state);
> -}
> -
> void i40e_client_device_register(struct i40e_info *ldev, struct i40e_client *client);
> void i40e_client_device_unregister(struct i40e_info *ldev);
>
next prev parent reply other threads:[~2022-01-26 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 18:55 [PATCH] i40e: remove enum i40e_client_state Jakub Kicinski
2022-01-26 19:53 ` Jesse Brandeburg [this message]
2022-01-26 19:59 ` Jakub Kicinski
2022-01-31 5:39 ` [Intel-wired-lan] " G, GurucharanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6675f9-63ce-77a2-e4fe-76cc592e5f41@intel.com \
--to=jesse.brandeburg@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shiraz.saleem@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox