Subject: Re: [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers

From: <[email-masked]>
Date: Sat, 15 May 2021 12:46:45 +0000

On 15/05/2021 at 12:53, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> 
> Cc: Nicolas Ferre <[email-masked]>

Ok, if it raises a warning.

But I would prefer that you add drivers/net/ethernet/cadence/macb_pci.c 
with same change to a combined patch.

Regards,
   Nicolas

> Cc: Claudiu Beznea <[email-masked]>
> Signed-off-by: Yang Shen <[email-masked]>
> ---
>   drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
> index 283918a..5c368a9 100644
> --- a/drivers/net/ethernet/cadence/macb_ptp.c
> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
> @@ -1,5 +1,5 @@
>   // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
>    * 1588 PTP support for Cadence GEM device.
>    *
>    * Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
> --
> 2.7.4
> 

-- 
Nicolas Ferre