Subject: Re: [PATCH] NETIF_F_LLTX for devices 2

From: Andrew Grover <[email-masked]>
Date: Sun, 12 Sep 2004 19:52:43 -0700

On 12 Sep 2004 13:34:30 -0400, jamal <[email-masked]> wrote:
> On Sun, 2004-09-12 at 12:16, Jeff Garzik wrote:
> > Thanks, but still need a patch for return value constants, otherwise you
> > are compounding rather than addressing a current problem.
> 
> Something along the lines of attached patch?
> Francois needs to update the doc and you need someone to get the
> janitors enthusiastic (i just updated e1000)

+#define NETDEV_TX_OK 0		/* driver took care of packet */
+#define NETDEV_TX_BUSY 1	/* driver tx path was busy*/
+#define NETDEV_TX_LOCKED -1	/* driver tx lock was already taken */

Why is TX_LOCKED -1 instead of, say, 2?

(The actual values are now irrelevant, right? Non sequential consts
makes one think their value is still important in some way. Maybe it's
just me.)

-- Andy