From: Ihar Hrachyshka <ihrachys@redhat•com>
To: Julian Anastasov <ja@ssi•bg>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH v2 2/4] arp: decompose is_garp logic into a separate function
Date: Wed, 24 May 2017 14:38:16 -0700 [thread overview]
Message-ID: <c19db1bf-eacd-32d5-4db6-1693715378b6@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1705182342140.4645@ja.home.ssi.bg>
On 05/18/2017 01:49 PM, Julian Anastasov wrote:
> All 4 patches look ok to me with only a small problem
> which comes from patch already included in kernel. I see
> that GARP replies can not work for 1394, is_garp will be
> cleared. May be 'tha' check should be moved in if expression,
> for example:
>
> if (is_garp && ar_op == htons(ARPOP_REPLY) && tha)
> is_garp = !memcmp(tha, sha, dev->addr_len);
I can easily miss something substantial, so please correct me, but...
If it's of REPLY type, the RFC 2002 requires that target hardware
address field equals to source address field for a packet to be
considered gratuitous. Since IEEE 1394 ARP standard defines its payload
without target field, it seems to me that there is no such thing as a
gratuitous ARP reply for IEEE 1394. That's why I think resetting is_garp
to 0 for those packets is justified.
Ihar
next prev parent reply other threads:[~2017-05-24 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 19:41 [PATCH v2 0/4] arp: always override existing neigh entries with gratuitous ARP Ihar Hrachyshka
2017-05-18 19:41 ` [PATCH v2 1/4] arp: fixed error in a comment Ihar Hrachyshka
2017-05-18 19:41 ` [PATCH v2 2/4] arp: decompose is_garp logic into a separate function Ihar Hrachyshka
2017-05-18 20:49 ` Julian Anastasov
2017-05-24 21:38 ` Ihar Hrachyshka [this message]
2017-05-18 19:41 ` [PATCH v2 3/4] arp: postpone addr_type calculation to as late as possible Ihar Hrachyshka
2017-05-18 19:41 ` [PATCH v2 4/4] arp: always override existing neigh entries with gratuitous ARP Ihar Hrachyshka
2017-05-21 17:27 ` [PATCH v2 0/4] " David Miller
2017-05-23 20:56 ` Arnd Bergmann
2017-05-24 21:32 ` Ihar Hrachyshka
2017-05-24 21:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c19db1bf-eacd-32d5-4db6-1693715378b6@redhat.com \
--to=ihrachys@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ja@ssi$(echo .)bg \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox