From: Matthieu Baerts <matttbe@kernel•org>
To: Jason Xing <kerneljasonxing@gmail•com>
Cc: Eric Dumazet <edumazet@google•com>,
dsahern@kernel•org, martineau@kernel•org, geliang@kernel•org,
kuba@kernel•org, pabeni@redhat•com, davem@davemloft•net,
rostedt@goodmis•org, mhiramat@kernel•org,
mathieu.desnoyers@efficios•com, atenart@kernel•org,
mptcp@lists•linux.dev, netdev@vger•kernel.org,
Jason Xing <kernelxing@tencent•com>
Subject: Re: [PATCH net-next v4 4/6] tcp: support rstreason for passive reset
Date: Tue, 16 Apr 2024 22:22:55 +0200 (GMT+02:00) [thread overview]
Message-ID: <c64c8a6c-2e24-43ca-8ee7-7e15547ed2d1@kernel.org> (raw)
In-Reply-To: <CAL+tcoDVFtvg6+Kio9frU5W=2e2n7qrCJkitXUxNjsouAG+iGg@mail.gmail.com>
Hi Jason,
16 Apr 2024 14:25:13 Jason Xing <kerneljasonxing@gmail•com>:
> On Tue, Apr 16, 2024 at 3:45 PM Jason Xing <kerneljasonxing@gmail•com> wrote:
>>
>> On Tue, Apr 16, 2024 at 2:34 PM Eric Dumazet <edumazet@google•com> wrote:
>>>
>>> On Thu, Apr 11, 2024 at 1:57 PM Jason Xing <kerneljasonxing@gmail•com> wrote:
>>>>
>>>> From: Jason Xing <kernelxing@tencent•com>
>>>>
>>>> Reuse the dropreason logic to show the exact reason of tcp reset,
>>>> so we don't need to implement those duplicated reset reasons.
>>>> This patch replaces all the prior NOT_SPECIFIED reasons.
>>>>
>>>> Signed-off-by: Jason Xing <kernelxing@tencent•com>
>>>> ---
>>>> net/ipv4/tcp_ipv4.c | 8 ++++----
>>>> net/ipv6/tcp_ipv6.c | 8 ++++----
>>>> 2 files changed, 8 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
>>>> index 441134aebc51..863397c2a47b 100644
>>>> --- a/net/ipv4/tcp_ipv4.c
>>>> +++ b/net/ipv4/tcp_ipv4.c
>>>> @@ -1935,7 +1935,7 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
>>>> return 0;
>>>>
>>>> reset:
>>>> - tcp_v4_send_reset(rsk, skb, SK_RST_REASON_NOT_SPECIFIED);
>>>> + tcp_v4_send_reset(rsk, skb, (u32)reason);
>>>> discard:
>>>> kfree_skb_reason(skb, reason);
>>>> /* Be careful here. If this function gets more complicated and
>>>> @@ -2278,7 +2278,7 @@ int tcp_v4_rcv(struct sk_buff *skb)
>>>> } else {
>>>> drop_reason = tcp_child_process(sk, nsk, skb);
>>>> if (drop_reason) {
>>>> - tcp_v4_send_reset(nsk, skb, SK_RST_REASON_NOT_SPECIFIED);
>>>> + tcp_v4_send_reset(nsk, skb, (u32)drop_reason);
>>>
>>> Are all these casts really needed ?
>>
>> Not really. If without, the compiler wouldn't complain about it.
>
> The truth is mptcp CI treats it as an error (see link[1]) when I
> submitted the V5 patchset but my machine works well. I wonder whether
> I should not remove all the casts or ignore the warnings?
Please do not ignore the warnings, they are not specific to the
MPTCP CI, they are also visible on the Netdev CI, and avoidable:
https://patchwork.kernel.org/project/netdevbpf/patch/20240416114003.62110-5-kerneljasonxing@gmail.com/
Cheers,
Matt
next prev parent reply other threads:[~2024-04-16 20:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 11:56 [PATCH net-next v4 0/6] Implement reset reason mechanism to detect Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 1/6] net: introduce rstreason to detect why the RST is sent Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 2/6] rstreason: prepare for passive reset Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 3/6] rstreason: prepare for active reset Jason Xing
2024-04-16 8:01 ` Paolo Abeni
2024-04-16 8:27 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 4/6] tcp: support rstreason for passive reset Jason Xing
2024-04-16 6:34 ` Eric Dumazet
2024-04-16 7:45 ` Jason Xing
2024-04-16 12:24 ` Jason Xing
2024-04-16 20:22 ` Matthieu Baerts [this message]
2024-04-17 0:23 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 5/6] mptcp: " Jason Xing
2024-04-16 6:33 ` Eric Dumazet
2024-04-16 7:45 ` Jason Xing
2024-04-16 8:04 ` Paolo Abeni
2024-04-16 8:19 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 6/6] rstreason: make it work in trace world Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c64c8a6c-2e24-43ca-8ee7-7e15547ed2d1@kernel.org \
--to=matttbe@kernel$(echo .)org \
--cc=atenart@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=geliang@kernel$(echo .)org \
--cc=kerneljasonxing@gmail$(echo .)com \
--cc=kernelxing@tencent$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=martineau@kernel$(echo .)org \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=mptcp@lists$(echo .)linux.dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox