From: "Tantilov, Emil S" <emil.s.tantilov@intel•com>
To: Leon Romanovsky <leon@kernel•org>
Cc: Pavan Kumar Linga <pavan.kumar.linga@intel•com>,
<intel-wired-lan@lists•osuosl.org>, <netdev@vger•kernel.org>,
<joshua.a.hay@intel•com>, <sridhar.samudrala@intel•com>,
<jesse.brandeburg@intel•com>, <anthony.l.nguyen@intel•com>,
<willemb@google•com>, <decot@google•com>, <pabeni@redhat•com>,
<kuba@kernel•org>, <edumazet@google•com>, <davem@davemloft•net>,
Phani Burra <phani.r.burra@intel•com>,
Alan Brady <alan.brady@intel•com>,
Madhu Chittim <madhu.chittim@intel•com>,
Shailendra Bhatnagar <shailendra.bhatnagar@intel•com>
Subject: Re: [PATCH net-next v2 02/15] idpf: add module register and probe functionality
Date: Thu, 13 Apr 2023 11:58:44 -0700 [thread overview]
Message-ID: <c95589a0-e25b-e8be-ebbe-7f99d801c230@intel.com> (raw)
In-Reply-To: <20230413060357.GC182481@unreal>
On 4/12/2023 11:03 PM, Leon Romanovsky wrote:
> On Wed, Apr 12, 2023 at 04:10:18PM -0700, Tantilov, Emil S wrote:
>>
>>
>> On 4/11/2023 5:36 AM, Leon Romanovsky wrote:
>>> On Mon, Apr 10, 2023 at 06:13:41PM -0700, Pavan Kumar Linga wrote:
>>>> From: Phani Burra <phani.r.burra@intel•com>
>>>>
>>>> Add the required support to register IDPF PCI driver, as well as
>>>> probe and remove call backs. Enable the PCI device and request
>>>> the kernel to reserve the memory resources that will be used by the
>>>> driver. Finally map the BAR0 address space.
>>>>
>>>> PCI IDs table is intentionally left blank to prevent the kernel from
>>>> probing the device with the incomplete driver. It will be added
>>>> in the last patch of the series.
>>>>
>>>> Signed-off-by: Phani Burra <phani.r.burra@intel•com>
>>>> Co-developed-by: Alan Brady <alan.brady@intel•com>
>>>> Signed-off-by: Alan Brady <alan.brady@intel•com>
>>>> Co-developed-by: Madhu Chittim <madhu.chittim@intel•com>
>>>> Signed-off-by: Madhu Chittim <madhu.chittim@intel•com>
>>>> Co-developed-by: Shailendra Bhatnagar <shailendra.bhatnagar@intel•com>
>>>> Signed-off-by: Shailendra Bhatnagar <shailendra.bhatnagar@intel•com>
>>>> Co-developed-by: Pavan Kumar Linga <pavan.kumar.linga@intel•com>
>>>> Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel•com>
>>>> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel•com>
>>>> Reviewed-by: Willem de Bruijn <willemb@google•com>
>>>> ---
>>>> drivers/net/ethernet/intel/Kconfig | 11 +++
>>>> drivers/net/ethernet/intel/Makefile | 1 +
>>>> drivers/net/ethernet/intel/idpf/Makefile | 10 ++
>>>> drivers/net/ethernet/intel/idpf/idpf.h | 27 ++++++
>>>> .../net/ethernet/intel/idpf/idpf_controlq.h | 14 +++
>>>> drivers/net/ethernet/intel/idpf/idpf_lib.c | 96 +++++++++++++++++++
>>>> drivers/net/ethernet/intel/idpf/idpf_main.c | 70 ++++++++++++++
>>>> 7 files changed, 229 insertions(+)
>>>> create mode 100644 drivers/net/ethernet/intel/idpf/Makefile
>>>> create mode 100644 drivers/net/ethernet/intel/idpf/idpf.h
>>>> create mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq.h
>>>> create mode 100644 drivers/net/ethernet/intel/idpf/idpf_lib.c
>>>> create mode 100644 drivers/net/ethernet/intel/idpf/idpf_main.c
>>>
>>> <...>
>
> <...>
>
>>>> +/**
>>>> + * idpf_probe - Device initialization routine
>>>> + * @pdev: PCI device information struct
>>>> + * @ent: entry in idpf_pci_tbl
>>>> + *
>>>> + * Returns 0 on success, negative on failure
>>>> + */
>>>> +static int idpf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>>> +{
>>>> + struct idpf_adapter *adapter;
>>>> +
>>>> + adapter = devm_kzalloc(&pdev->dev, sizeof(*adapter), GFP_KERNEL);
>>>
>>> Why devm_kzalloc() and not kzalloc?
>> It provides managed memory allocation on probe, which seems to be the
>> preferred method in that case.
>
> I don't think so, as PCI probe/remove has very clear lifetime model and
> doesn't need garbage collection memory logic. In general, it is better
> to avoid devm_*() APIs as they hide error unwind flows.
We'll remove it in v3.
Thanks,
Emil
> Thanks
next prev parent reply other threads:[~2023-04-13 18:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 1:13 [PATCH net-next v2 00/15] Introduce Intel IDPF driver Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 01/15] virtchnl: add virtchnl version 2 ops Pavan Kumar Linga
2023-04-11 8:51 ` Simon Horman
2023-04-12 21:38 ` Tantilov, Emil S
2023-04-11 1:13 ` [PATCH net-next v2 02/15] idpf: add module register and probe functionality Pavan Kumar Linga
2023-04-11 12:36 ` Leon Romanovsky
2023-04-12 23:10 ` Tantilov, Emil S
2023-04-13 6:03 ` Leon Romanovsky
2023-04-13 18:58 ` Tantilov, Emil S [this message]
2023-04-20 18:13 ` [Intel-wired-lan] " Tantilov, Emil S
2023-04-20 18:20 ` Leon Romanovsky
2023-04-11 1:13 ` [PATCH net-next v2 03/15] idpf: add controlq init and reset checks Pavan Kumar Linga
2023-04-11 9:19 ` Simon Horman
2023-04-11 1:13 ` [PATCH net-next v2 04/15] idpf: add core init and interrupt request Pavan Kumar Linga
2023-04-11 9:52 ` Simon Horman
2023-04-13 19:10 ` Tantilov, Emil S
2023-04-11 1:13 ` [PATCH net-next v2 05/15] idpf: add create vport and netdev configuration Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 06/15] idpf: continue expanding init task Pavan Kumar Linga
2023-04-11 9:04 ` Simon Horman
2023-04-13 19:04 ` Tantilov, Emil S
2023-04-11 1:13 ` [PATCH net-next v2 07/15] idpf: configure resources for TX queues Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 08/15] idpf: configure resources for RX queues Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 09/15] idpf: initialize interrupts and enable vport Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 10/15] idpf: add splitq start_xmit Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 11/15] idpf: add TX splitq napi poll support Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 12/15] idpf: add RX " Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 13/15] idpf: add singleq start_xmit and napi poll Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 14/15] idpf: add ethtool callbacks Pavan Kumar Linga
2023-04-11 9:55 ` Simon Horman
2023-04-13 19:11 ` Tantilov, Emil S
2023-04-22 5:26 ` [Intel-wired-lan] " Tantilov, Emil S
2023-04-22 7:55 ` Simon Horman
2023-04-11 1:13 ` [PATCH net-next v2 15/15] idpf: configure SRIOV and add other ndo_ops Pavan Kumar Linga
2023-04-12 18:25 ` [Intel-wired-lan] [PATCH net-next v2 00/15] Introduce Intel IDPF driver Sasha Levin
2023-04-12 19:16 ` Willem de Bruijn
2023-04-13 0:03 ` Samudrala, Sridhar
2023-04-13 2:24 ` Jakub Kicinski
2023-04-13 7:15 ` Leon Romanovsky
2023-04-14 22:01 ` Sasha Levin
2023-04-14 22:27 ` Jakub Kicinski
2023-04-15 17:16 ` Sasha Levin
2023-04-17 16:38 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2023-06-14 17:14 [PATCH net-next v2 00/15][pull request] " Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 02/15] idpf: add module register and probe functionality Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c95589a0-e25b-e8be-ebbe-7f99d801c230@intel.com \
--to=emil.s.tantilov@intel$(echo .)com \
--cc=alan.brady@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=decot@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=joshua.a.hay@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=madhu.chittim@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.kumar.linga@intel$(echo .)com \
--cc=phani.r.burra@intel$(echo .)com \
--cc=shailendra.bhatnagar@intel$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox