From: Martin KaFai Lau <martin.lau@linux•dev>
To: Zhu Yanjun <yanjun.zhu@linux•dev>,
"D. Wythe" <alibuda@linux•alibaba.com>
Cc: kgraul@linux•ibm.com, wenjia@linux•ibm.com, jaka@linux•ibm.com,
ast@kernel•org, daniel@iogearbox•net, andrii@kernel•org,
pabeni@redhat•com, song@kernel•org, sdf@google•com,
haoluo@google•com, yhs@fb•com, edumazet@google•com,
john.fastabend@gmail•com, kpsingh@kernel•org, jolsa@kernel•org,
guwen@linux•alibaba.com, kuba@kernel•org, davem@davemloft•net,
netdev@vger•kernel.org, linux-s390@vger•kernel.org,
linux-rdma@vger•kernel.org, bpf@vger•kernel.org,
dtcccc@linux•alibaba.com
Subject: Re: [PATCH bpf-next 4/4] bpf/selftests: add simple selftest for bpf_smc_ops
Date: Mon, 25 Nov 2024 15:32:25 -0800 [thread overview]
Message-ID: <c96fe7a8-8512-48e8-b253-d5ff8a0f4755@linux.dev> (raw)
In-Reply-To: <0a8c2285-29c2-4a79-b704-c2baeac90b70@linux.dev>
On 11/25/24 2:52 AM, Zhu Yanjun wrote:
>>> # ./test_progs -t smc
>>> #27/1 bpf_smc/load:OK
>>> #27 bpf_smc:OK
>>> Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
>>>
>>> The above command is based on several kernel modules. After these dependent
>>> kernel modules are loaded, then can run the above command successfully.
>>
>> This is indeed a problem, a better way may be to create a separate testing
>> directory for SMC, and we are trying to do this.
>
> Got it. In the latest patch series, if a test program in sample/bpf can verify
> this bpf feature, it is better than a selftest program in the directory tools/
> testing/selftests/bpf.
>
> I delved into this selftest tool. It seems that this selftest tool only makes
> the basic checks. A test program in sample/bpf can do more.
sample(s)/bpf? No new test should be added to samples/bpf which is obsolete. The
bpf CI only runs tests under selftests/bpf.
There is selftests/bpf/config to tell the bpf CI about what kconfig needs to
turn on.
next prev parent reply other threads:[~2024-11-25 23:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 2:42 [PATCH bpf-next 0/4] net/smc: Introduce smc_bpf_ops D. Wythe
2024-10-24 2:42 ` [PATCH bpf-next 1/4] bpf: export necessary sympols for modules D. Wythe
2024-10-24 2:42 ` [PATCH bpf-next 2/4] bpf: allow to access bpf_prog during bpf_struct_access D. Wythe
2024-10-25 9:14 ` kernel test robot
2024-10-25 12:20 ` kernel test robot
2024-10-24 2:42 ` [PATCH net-next 3/4] net/smc: Introduce smc_bpf_ops D. Wythe
2024-10-25 0:26 ` Martin KaFai Lau
2024-10-25 11:05 ` D. Wythe
2024-10-25 18:30 ` Martin KaFai Lau
2024-10-29 8:53 ` D. Wythe
2024-10-24 2:42 ` [PATCH bpf-next 4/4] bpf/selftests: add simple selftest for bpf_smc_ops D. Wythe
2024-10-24 4:04 ` D. Wythe
2024-10-24 4:49 ` Tianchen Ding
2024-10-24 5:49 ` D. Wythe
2024-11-03 13:01 ` Zhu Yanjun
2024-11-21 2:00 ` D. Wythe
2024-11-25 10:52 ` Zhu Yanjun
2024-11-25 23:32 ` Martin KaFai Lau [this message]
2024-11-26 8:29 ` Zhu Yanjun
2024-11-29 4:11 ` D. Wythe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c96fe7a8-8512-48e8-b253-d5ff8a0f4755@linux.dev \
--to=martin.lau@linux$(echo .)dev \
--cc=alibuda@linux$(echo .)alibaba.com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dtcccc@linux$(echo .)alibaba.com \
--cc=edumazet@google$(echo .)com \
--cc=guwen@linux$(echo .)alibaba.com \
--cc=haoluo@google$(echo .)com \
--cc=jaka@linux$(echo .)ibm.com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kgraul@linux$(echo .)ibm.com \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=song@kernel$(echo .)org \
--cc=wenjia@linux$(echo .)ibm.com \
--cc=yanjun.zhu@linux$(echo .)dev \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox