Subject: Re: [PATCH v3 net-next 5/8] net: dsa: b53: add MTU configuration support

From: Florian Fainelli <[email-masked]>
Date: Thu, 26 Mar 2020 16:16:38 -0700

On 3/26/2020 3:40 PM, Vladimir Oltean wrote:
> From: Murali Krishna Policharla <[email-masked]>
> 
> It looks like the Broadcomm switches supported by the b53 driver don't
                            ^= one too many m's, the attempt to acquire
Qualcomm failed a few years ago :)

> support precise configuration of the MTU, but just a mumbo-jumbo boolean
> flag. Set that.
> 
> Also configure BCM583XX devices to send and receive jumbo frames when
> ports are configured with 10/100 Mbps speed.
> 
> Signed-off-by: Murali Krishna Policharla <[email-masked]>
> Signed-off-by: Vladimir Oltean <[email-masked]>
> ---

[snip]

> +static int b53_change_mtu(struct dsa_switch *ds, int port, int mtu)
> +{
> +	struct b53_device *dev = ds->priv;
> +	bool enable_jumbo;
> +	bool allow_10_100;
> +
> +	if (is5325(dev) || is5365(dev))
> +		return -EOPNOTSUPP;
> +
> +	enable_jumbo = (mtu >= JMS_MIN_SIZE);
> +	allow_10_100 = (dev->chip_id == BCM58XX_DEVICE_ID);

I believe this was meant to be BCM583XX_DEVICE_ID to be consistent with
the previous patch version. With that:

Acked-by: Florian Fainelli <[email-masked]>
-- 
Florian