From: "Austin, Alex (DCCG)" <alexaust@amd•com>
To: Jakub Kicinski <kuba@kernel•org>, Alex Austin <alex.austin@amd•com>
Cc: netdev@vger•kernel.org, linux-net-drivers@amd•com,
ecree.xilinx@gmail•com, habetsm.xilinx@gmail•com,
davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
richardcochran@gmail•com, lorenzo@kernel•org, memxor@gmail•com,
alardam@gmail•com, bhelgaas@google•com
Subject: Re: [PATCH net-next 1/2] sfc: Implement ndo_hwtstamp_(get|set)
Date: Mon, 4 Dec 2023 10:26:30 +0000 [thread overview]
Message-ID: <ca89ea1b-eaa5-4429-b99c-cf0e40c248db@amd.com> (raw)
In-Reply-To: <20231201192531.2d35fb39@kernel.org>
This seems like a good approach. I'll re-work into a v2.
Alex
On 02/12/2023 03:25, Jakub Kicinski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Thu, 30 Nov 2023 13:58:25 +0000 Alex Austin wrote:
>> - struct hwtstamp_config config;
>> + struct kernel_hwtstamp_config config;
>> + *config = efx->ptp_data->config;
> Do we have a lot of places which assign the new structure directly
> like this?
>
> There's a bit of "request state" in it:
>
> struct kernel_hwtstamp_config {
> int flags;
> int tx_type;
> int rx_filter;
> struct ifreq *ifr; <<<
> bool copied_to_user; <<<
> enum hwtstamp_source source;
> };
>
> Maybe keep the type of config as was, and use
> hwtstamp_config_to_kernel() to set the right fields?
next prev parent reply other threads:[~2023-12-04 10:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 13:58 [PATCH net-next 0/2] sfc: Implement ndo_hwtstamp_(get|set) Alex Austin
2023-11-30 13:58 ` [PATCH net-next 1/2] " Alex Austin
2023-11-30 19:04 ` Edward Cree
2023-12-02 3:25 ` Jakub Kicinski
2023-12-04 10:26 ` Austin, Alex (DCCG) [this message]
2023-12-04 11:00 ` Vladimir Oltean
2023-12-04 18:17 ` Jakub Kicinski
2023-12-04 18:45 ` Vladimir Oltean
2023-12-05 8:52 ` Paolo Abeni
2023-12-05 13:45 ` Austin, Alex (DCCG)
2023-12-05 13:46 ` Vladimir Oltean
2023-11-30 13:58 ` [PATCH net-next 2/2] sfc-siena: " Alex Austin
2023-11-30 19:05 ` Edward Cree
2023-12-05 13:47 ` Vladimir Oltean
2023-12-05 17:20 ` [PATCH net-next 0/2] sfc: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca89ea1b-eaa5-4429-b99c-cf0e40c248db@amd.com \
--to=alexaust@amd$(echo .)com \
--cc=alardam@gmail$(echo .)com \
--cc=alex.austin@amd$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=habetsm.xilinx@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=lorenzo@kernel$(echo .)org \
--cc=memxor@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox