public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse•cz>
To: netdev@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>,
	Patrick McHardy <kaber@trash•net>,
	John Fastabend <john.r.fastabend@intel•com>
Subject: [PATCH net v2 0/2] macvlan: disable LRO on lowerdev instead of a macvlan
Date: Thu, 14 Nov 2013 15:00:06 +0100 (CET)	[thread overview]
Message-ID: <cover.1384436410.git.mkubecek@suse.cz> (raw)

A customer of ours encountered a problem with LRO on an ixgbe network
card. Analysis showed that it was a known conflict of forwarding and LRO
but the forwarding was enabled in an LXC container where only a macvlan
was, not the ethernet device itself.

I believe the solution is exactly the same as what we do for "normal"
(802.1q) VLAN devices: if dev_disable_lro() is called for such device,
LRO is disabled on the underlying "real" device instead.

v2: adapt to changes merged from net-next

Michal Kubecek (2):
  macvlan: introduce macvlan_dev_real_dev() helper function
  macvlan: disable LRO on lower device instead of macvlan

 include/linux/if_macvlan.h | 16 ++++++++++++++++
 net/core/dev.c             |  5 +++++
 2 files changed, 21 insertions(+)

-- 
1.8.1.4

             reply	other threads:[~2013-11-14 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 14:00 Michal Kubecek [this message]
2013-11-14 14:00 ` [PATCH net v2 1/2] macvlan: introduce macvlan_dev_real_dev() helper function Michal Kubecek
2013-11-14 15:03   ` Vlad Yasevich
2013-11-14 15:57     ` Michal Kubecek
2013-11-14 22:03       ` David Miller
2013-11-15  5:26         ` Michal Kubecek
2013-11-15  2:43       ` Vlad Yasevich
2013-11-14 14:00 ` [PATCH net v2 2/2] macvlan: disable LRO on lower device instead of macvlan Michal Kubecek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1384436410.git.mkubecek@suse.cz \
    --to=mkubecek@suse$(echo .)cz \
    --cc=davem@davemloft$(echo .)net \
    --cc=john.r.fastabend@intel$(echo .)com \
    --cc=kaber@trash$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox