From: Sabrina Dubroca <sd@queasysnail•net>
To: netdev@vger•kernel.org
Cc: Phil Sutter <phil@nwl•cc>,
Stephen Hemminger <stephen@networkplumber•org>,
Sabrina Dubroca <sd@queasysnail•net>
Subject: [PATCH iproute2 0/4] improve initialization of genl handle
Date: Tue, 16 Aug 2016 16:26:54 +0200 [thread overview]
Message-ID: <cover.1471356460.git.sd@queasysnail.net> (raw)
This patchset fixes several issues for users of genetlink:
- Duplicated code for initialization of a genl handle.
All users of genl must open a socket and resolve the family, and
use the same code to do that.
Solution: add a library function.
- genl family resolution fails when the module that handles this
family is not loaded yet.
This means that if we try to initialize the genl handle early in
handling the command, we cannot display usage, because we fail hard
when trying to resolve the genl family.
Solution: move the genl handle initialization after handling the
`ip * help` case.
Sabrina Dubroca (4):
libgenl: introduce genl_init_handle
macsec: show usage even if the module is not available
fou: show usage even if the module is not available
ila: show usage even if the module is not available
include/libgenl.h | 2 ++
ip/ipfou.c | 20 ++++++--------------
ip/ipila.c | 19 ++++++-------------
ip/ipl2tp.c | 12 ++----------
ip/ipmacsec.c | 20 +++-----------------
ip/tcp_metrics.c | 14 +++-----------
lib/libgenl.c | 17 +++++++++++++++++
7 files changed, 39 insertions(+), 65 deletions(-)
--
2.9.3
next reply other threads:[~2016-08-16 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 14:26 Sabrina Dubroca [this message]
2016-08-16 14:26 ` [PATCH iproute2 1/4] libgenl: introduce genl_init_handle Sabrina Dubroca
2016-08-16 14:26 ` [PATCH iproute2 2/4] macsec: show usage even if the module is not available Sabrina Dubroca
2016-08-16 14:26 ` [PATCH iproute2 3/4] fou: " Sabrina Dubroca
2016-08-16 14:26 ` [PATCH iproute2 4/4] ila: " Sabrina Dubroca
2016-08-23 9:18 ` [PATCH iproute2 0/4] improve initialization of genl handle Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1471356460.git.sd@queasysnail.net \
--to=sd@queasysnail$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=phil@nwl$(echo .)cc \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox