public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle•com>
To: netdev@vger•kernel.org
Cc: santosh.shilimkar@oracle•com, sowmini.varadhan@oracle•com,
	davem@davemloft•net, rds-devel@oss•oracle.com
Subject: [PATCH net-next 0/3] RDS: TCP: HA/Failover fixes
Date: Wed, 16 Nov 2016 13:29:47 -0800	[thread overview]
Message-ID: <cover.1478876910.git.sowmini.varadhan@oracle.com> (raw)

This series contains a set of fixes for bugs exposed when
we ran the following in a loop between a test machine pair:

 while (1); do
   # modprobe rds-tcp on test nodes
   # run rds-stress in bi-dir mode between test machine pair 
   # modprobe -r rds-tcp on test nodes
 done

rds-stress in bi-dir mode will cause both nodes to initiate
RDS-TCP connections at almost the same instant, exposing the 
bugs fixed in this series. 

Without the fixes, rds-stress reports sporadic packet drops,
and packets arriving out of sequence. After the fixes,we have
been able to run the  test overnight, without any issues.

Each patch has a detailed description of the root-cause fixed
by the patch.


Sowmini Varadhan (3):
  RDS: TCP: set RDS_FLAG_RETRANSMITTED in cp_retrans list
  RDS: TCP: Track peer's connection generation number
  RDS: TCP: Force every connection to be initiated by numerically
    smaller IP address

 net/rds/af_rds.c      |    4 ++++
 net/rds/connection.c  |    3 +++
 net/rds/message.c     |    1 +
 net/rds/rds.h         |    8 +++++++-
 net/rds/recv.c        |   36 ++++++++++++++++++++++++++++++++++++
 net/rds/send.c        |    9 +++++++--
 net/rds/tcp_connect.c |   14 +++++++++++++-
 net/rds/tcp_listen.c  |   29 ++++++++++++-----------------
 net/rds/tcp_send.c    |    3 +++
 9 files changed, 86 insertions(+), 21 deletions(-)

             reply	other threads:[~2016-11-16 21:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 21:29 Sowmini Varadhan [this message]
2016-11-16 21:29 ` [PATCH net-next 1/3] RDS: TCP: set RDS_FLAG_RETRANSMITTED in cp_retrans list Sowmini Varadhan
2016-11-16 21:29 ` [PATCH net-next 2/3] RDS: TCP: Track peer's connection generation number Sowmini Varadhan
2016-11-16 21:29 ` [PATCH net-next 3/3] RDS: TCP: Force every connection to be initiated by numerically smaller IP address Sowmini Varadhan
2016-11-17 18:35 ` [PATCH net-next 0/3] RDS: TCP: HA/Failover fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1478876910.git.sowmini.varadhan@oracle.com \
    --to=sowmini.varadhan@oracle$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=rds-devel@oss$(echo .)oracle.com \
    --cc=santosh.shilimkar@oracle$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox