From: Petr Machata <petrm@mellanox•com>
To: netdev@vger•kernel.org
Cc: David Miller <davem@davemloft•net>,
Petr Machata <petrm@mellanox•com>,
idosch@mellanox•com, jiri@mellanox•com, alexpe@mellanox•com
Subject: [PATCH net-next 0/3] Implement stats_update callback for pedit and skbedit
Date: Thu, 26 Mar 2020 22:45:54 +0200 [thread overview]
Message-ID: <cover.1585255467.git.petrm@mellanox.com> (raw)
The stats_update callback is used for adding HW counters to the SW ones.
Both skbedit and pedit actions are actually recognized by flow_offload.h,
but do not implement these callbacks. As a consequence, the reported values
are only the SW ones, even where there is a HW counter available.
Patch #1 adds the callback to action skbedit, patch #2 adds it to action
pedit. Patch #3 tweaks an skbedit selftest with a check that would have
caught this problem.
The pedit test is not likewise tweaked, because the iproute2 pedit action
currently does not support JSON dumping. This will be addressed later.
Petr Machata (3):
sched: act_skbedit: Implement stats_update callback
sched: act_pedit: Implement stats_update callback
selftests: skbedit_priority: Test counters at the skbedit rule
net/sched/act_pedit.c | 11 +++++++++++
net/sched/act_skbedit.c | 11 +++++++++++
.../selftests/net/forwarding/skbedit_priority.sh | 9 +++++++--
3 files changed, 29 insertions(+), 2 deletions(-)
--
2.20.1
next reply other threads:[~2020-03-26 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 20:45 Petr Machata [this message]
2020-03-26 20:45 ` [PATCH net-next 1/3] sched: act_skbedit: Implement stats_update callback Petr Machata
2020-03-26 20:45 ` [PATCH net-next 2/3] sched: act_pedit: " Petr Machata
2020-03-26 20:45 ` [PATCH net-next 3/3] selftests: skbedit_priority: Test counters at the skbedit rule Petr Machata
2020-03-27 0:01 ` [PATCH net-next 0/3] Implement stats_update callback for pedit and skbedit Alexander Petrovskiy
2020-03-27 2:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1585255467.git.petrm@mellanox.com \
--to=petrm@mellanox$(echo .)com \
--cc=alexpe@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox