From: Xin Long <lucien.xin@gmail•com>
To: network dev <netdev@vger•kernel.org>,
tipc-discussion@lists•sourceforge.net
Cc: davem@davemloft•net, kuba@kernel•org,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Jon Maloy <jmaloy@redhat•com>,
Ying Xue <ying.xue@windriver•com>,
Wei Chen <harperchen1110@gmail•com>
Subject: [PATCH net 0/2] tipc: fix two race issues in tipc_conn_alloc
Date: Fri, 18 Nov 2022 16:44:59 -0500 [thread overview]
Message-ID: <cover.1668807842.git.lucien.xin@gmail.com> (raw)
The race exists beteen tipc_topsrv_accept() and tipc_conn_close(),
one is allocating the con while the other is freeing it and there
is no proper lock protecting it. Therefore, a null-pointer-defer
and a use-after-free may be triggered, see details on each patch.
Xin Long (2):
tipc: set con sock in tipc_conn_alloc
tipc: add an extra conn_get in tipc_conn_alloc
net/tipc/topsrv.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
--
2.31.1
next reply other threads:[~2022-11-18 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 21:44 Xin Long [this message]
2022-11-18 21:45 ` [PATCH net 1/2] tipc: set con sock in tipc_conn_alloc Xin Long
2022-11-18 21:45 ` [PATCH net 2/2] tipc: add an extra conn_get " Xin Long
2022-11-22 0:47 ` [PATCH net 0/2] tipc: fix two race issues " Jon Maloy
2022-11-22 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1668807842.git.lucien.xin@gmail.com \
--to=lucien.xin@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=harperchen1110@gmail$(echo .)com \
--cc=jmaloy@redhat$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox