From: Jacob Keller <jacob.e.keller@intel•com>
To: Jakub Kicinski <kuba@kernel•org>,
Stanislav Fomichev <sdf.kernel@gmail•com>
Cc: <davem@davemloft•net>, <netdev@vger•kernel.org>,
<edumazet@google•com>, <pabeni@redhat•com>,
<andrew+netdev@lunn•ch>, <horms@kernel•org>,
<michael.chan@broadcom•com>, <hkallweit1@gmail•com>,
<maxime.chevallier@bootlin•com>, <joshwash@google•com>,
<tariqt@nvidia•com>, <alexanderduyck@fb•com>,
<willemb@google•com>, <kory.maincent@bootlin•com>,
<jakub@cloudflare•com>, <nb@tipi-net•de>
Subject: Re: [PATCH net-next v2 00/12] net: ethtool: let ops locked drivers run without rtnl_lock
Date: Mon, 8 Jun 2026 15:04:03 -0700 [thread overview]
Message-ID: <d0efe754-785a-45be-8394-bcb027ae1a2d@intel.com> (raw)
In-Reply-To: <20260605170952.52c00c2e@kernel.org>
On 6/5/2026 5:09 PM, Jakub Kicinski wrote:
> On Fri, 5 Jun 2026 15:48:48 -0700 Stanislav Fomichev wrote:
>> netdev_ops_lock_dereference name trips me a bit (_compat suffix would've been
>> more obvious), but I do agree with the reasoning about needing 'a' lock..
>
> Guess I hate long lines more than I hate inconsistencies.
>
> This:
>
> something = netdev_lock_ops_compat_dereference(&dev->something, dev);
>
> is uncomfortably close to 80 columns for me.
>
> I think the existing naming is as good as we'll get..
> If y'all disagree I can respin. I'll be sad but I'll respin :)
I'm still working my way through the sseries, but I agree adding compat
here might avoid some confusion, but its extremely long and it forces
"something" to be pretty short. I think its already long and descriptive
enough.
next prev parent reply other threads:[~2026-06-08 22:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 0:29 [PATCH net-next v2 00/12] net: ethtool: let ops locked drivers run without rtnl_lock Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 01/12] net: ethtool: serialize broadcast notification sequence allocation Jakub Kicinski
2026-06-09 15:32 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 02/12] net: ethtool: relax ethnl_req_get_phydev() locking assertion Jakub Kicinski
2026-06-09 15:33 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 03/12] net: ethtool: make dev->hwprov ops-protected Jakub Kicinski
2026-06-09 15:35 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 04/12] net: ethtool: optionally skip rtnl_lock on Netlink path for GET ops Jakub Kicinski
2026-06-09 15:37 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 05/12] net: ethtool: optionally skip rtnl_lock on Netlink path for SET ops Jakub Kicinski
2026-06-08 22:15 ` Jacob Keller
2026-06-08 23:58 ` Jakub Kicinski
2026-06-09 1:01 ` Jacob Keller
2026-06-09 15:40 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 06/12] net: ethtool: optionally skip rtnl_lock in cable test handlers Jakub Kicinski
2026-06-08 22:17 ` Jacob Keller
2026-06-09 15:41 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 07/12] net: ethtool: optionally skip rtnl_lock in ethnl_tsinfo_dumpit() Jakub Kicinski
2026-06-09 15:42 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 08/12] net: ethtool: optionally skip rtnl_lock in ethnl_act_module_fw_flash() Jakub Kicinski
2026-06-09 15:43 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 09/12] net: ethtool: optionally skip rtnl_lock in RSS context handlers Jakub Kicinski
2026-06-09 15:44 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 10/12] net: ethtool: ioctl: concentrate the locking Jakub Kicinski
2026-06-09 15:46 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 11/12] net: ethtool: optionally skip rtnl_lock on IOCTL path Jakub Kicinski
2026-06-09 15:49 ` Eric Dumazet
2026-06-05 0:29 ` [PATCH net-next v2 12/12] docs: net: ethtool: document ops-locked drivers and op_needs_rtnl Jakub Kicinski
2026-06-09 15:50 ` Eric Dumazet
2026-06-05 22:48 ` [PATCH net-next v2 00/12] net: ethtool: let ops locked drivers run without rtnl_lock Stanislav Fomichev
2026-06-06 0:09 ` Jakub Kicinski
2026-06-08 15:20 ` Stanislav Fomichev
2026-06-08 22:04 ` Jacob Keller [this message]
2026-06-08 22:31 ` Jacob Keller
2026-06-08 23:01 ` Jacob Keller
2026-06-08 23:33 ` Tony Nguyen
2026-06-09 1:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0efe754-785a-45be-8394-bcb027ae1a2d@intel.com \
--to=jacob.e.keller@intel$(echo .)com \
--cc=alexanderduyck@fb$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jakub@cloudflare$(echo .)com \
--cc=joshwash@google$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=nb@tipi-net$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sdf.kernel@gmail$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox