From: Steve Wise <swise@opengridcomputing•com>
To: Leon Romanovsky <leon@kernel•org>
Cc: dsahern@gmail•com, stephen@networkplumber•org,
netdev@vger•kernel.org, linux-rdma@vger•kernel.org,
BMT@zurich•ibm.com
Subject: Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands
Date: Wed, 28 Nov 2018 14:18:55 -0600 [thread overview]
Message-ID: <d2aaeece-6491-b5f2-d1af-e6c327590cab@opengridcomputing.com> (raw)
In-Reply-To: <20181128201303.GR4559@mtr-leonro.mtl.com>
On 11/28/2018 2:13 PM, Leon Romanovsky wrote:
> On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote:
>>
>> On 11/28/2018 2:04 PM, Leon Romanovsky wrote:
>>> On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote:
>>>> On 11/28/2018 12:26 PM, Leon Romanovsky wrote:
>>>>> On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote:
>>>>>> Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma
>>>>>> device to a netdev interface.
>>>>>>
>>>>>> EG:
>>>>>>
>>>>>> rdma link add rxe_eth0 type rxe dev eth0
>>>>>> rdma link delete rxe_eth0
>>>>>>
>>>>>> Signed-off-by: Steve Wise <swise@opengridcomputing•com>
>>>>>> ---
>>>>>> rdma/link.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>>>> rdma/rdma.h | 1 +
>>>>>> rdma/utils.c | 2 +-
>>>>>> 3 files changed, 108 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/rdma/link.c b/rdma/link.c
>>>>>> index 7a6d4b7e356d..d4f76b0ce11f 100644
>>>>>> --- a/rdma/link.c
>>>>>> +++ b/rdma/link.c
>>>>>> @@ -14,6 +14,8 @@
>>>>>> static int link_help(struct rd *rd)
>>>>>> {
>>>>>> pr_out("Usage: %s link show [DEV/PORT_INDEX]\n", rd->filename);
>>>>>> + pr_out("Usage: %s link add NAME type TYPE dev DEV\n", rd->filename);
>>>>> I suggest to rename "dev" to be "netdev", because we are using "dev" for
>>>>> ib devices.
>>>> Yea ok.
>>>>
>>>>>> + pr_out("Usage: %s link delete NAME type TYPE\n", rd->filename);
>>>>> Why do you need "type" for "delete" command?
>>>> Because the type is used in the kernel to find the appropriate link
>>>> ops. I could change the kernel side to search all types for the device
>>>> name to delete?
>>> I would say, yes.
>>> It makes "delete" operation more natural.
>>>
>>> Thanks
>> Perhaps.
>>
>> Note: 'ip link delete' takes a type as well...
> According to man section, yes.
> According to various guides, no.
> https://docs.fedoraproject.org/en-US/Fedora/20/html/Networking_Guide/sec-Configure_802_1Q_VLAN_Tagging_ip_Commands.html
>
> Thanks
It does make sense to not require type. The name must be unique so that
should be enough. I'll have to respin the kernel side though...
Thanks,
Steve.
next prev parent reply other threads:[~2018-11-29 7:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 16:25 [PATCH RFC iproute2-next 0/2] Dynamic rdma link creation Steve Wise
2018-09-13 17:19 ` [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands Steve Wise
2018-11-28 18:26 ` Leon Romanovsky
2018-11-28 19:08 ` Steve Wise
2018-11-28 19:34 ` Steve Wise
2018-11-28 20:02 ` Leon Romanovsky
2018-11-28 20:08 ` Leon Romanovsky
2018-11-28 20:23 ` Steve Wise
2018-11-28 20:04 ` Leon Romanovsky
2018-11-28 20:07 ` Steve Wise
2018-11-28 20:13 ` Leon Romanovsky
2018-11-28 20:18 ` Steve Wise [this message]
2018-11-28 22:17 ` Jason Gunthorpe
2018-11-28 22:21 ` Steve Wise
2018-11-28 22:25 ` Jason Gunthorpe
2018-11-28 22:51 ` Steve Wise
2018-11-28 15:16 ` [PATCH RFC iproute2-next 2/2] rdma: man page update for link add/delete Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2aaeece-6491-b5f2-d1af-e6c327590cab@opengridcomputing.com \
--to=swise@opengridcomputing$(echo .)com \
--cc=BMT@zurich$(echo .)ibm.com \
--cc=dsahern@gmail$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox