From: Tariq Toukan <ttoukan.linux@gmail•com>
To: Jakub Kicinski <kuba@kernel•org>, Tariq Toukan <tariqt@nvidia•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
Leon Romanovsky <leonro@nvidia•com>,
netdev@vger•kernel.org, Saeed Mahameed <saeedm@nvidia•com>,
Gal Pressman <gal@nvidia•com>,
linux-rdma@vger•kernel.org
Subject: Re: [PATCH net-next V5 00/11] net/mlx5: ConnectX-8 SW Steering + Rate management on traffic classes
Date: Mon, 9 Dec 2024 21:32:11 +0200 [thread overview]
Message-ID: <d4890336-db2d-49f6-9502-6558cbaccefa@gmail.com> (raw)
In-Reply-To: <20241206181345.3eccfca4@kernel.org>
On 07/12/2024 4:13, Jakub Kicinski wrote:
> On Thu, 5 Dec 2024 00:09:20 +0200 Tariq Toukan wrote:
>> This patch series extends the devlink-rate API to support traffic class
>> (TC) bandwidth management, enabling more granular control over traffic
>> shaping and rate limiting across multiple TCs. The API now allows users
>> to specify bandwidth proportions for different traffic classes in a
>> single command. This is particularly useful for managing Enhanced
>> Transmission Selection (ETS) for groups of Virtual Functions (VFs),
>> allowing precise bandwidth allocation across traffic classes.
>>
>> Additionally the series refines the QoS handling in net/mlx5 to support
>> TC arbitration and bandwidth management on vports and rate nodes.
>>
>> Extend devlink-rate API to support rate management on TCs:
>> - devlink: Extend the devlink rate API to support traffic class
>> bandwidth management
>>
>> Introduce a no-op implementation:
>> - net/mlx5: Add no-op implementation for setting tc-bw on rate objects
>>
>> Add support for enabling and disabling TC QoS on vports and nodes:
>> - net/mlx5: Add support for setting tc-bw on nodes
>> - net/mlx5: Add traffic class scheduling support for vport QoS
>>
>> Support for setting tc-bw on rate objects:
>> - net/mlx5: Manage TC arbiter nodes and implement full support for
>> tc-bw
>
> Do you expect TC bw allocation to work on non-leaf nodes?
>
Yes. That's the point. It works.
> How does this relate to the rate API which Paolo added? He was asked
> to build in a way to integrate with devlink now devlink is growing
> extra features again, which presumably the other API will also need.
> And the integration may turn out to be challenging.
>
AFAIU Paolo's work is not for shapers 'above' the network device level,
i.e. groups.
next prev parent reply other threads:[~2024-12-09 19:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 22:09 [PATCH net-next V5 00/11] net/mlx5: ConnectX-8 SW Steering + Rate management on traffic classes Tariq Toukan
2024-12-04 22:09 ` [PATCH mlx5-next V5 01/11] net/mlx5: ifc: Reorganize mlx5_ifc_flow_table_context_bits Tariq Toukan
2024-12-04 22:09 ` [PATCH mlx5-next V5 02/11] net/mlx5: Add ConnectX-8 device to ifc Tariq Toukan
2024-12-04 22:09 ` [PATCH mlx5-next V5 03/11] net/mlx5: Add support for new scheduling elements Tariq Toukan
2024-12-04 22:09 ` [PATCH mlx5-next V5 04/11] net/mlx5: qos: Add ifc support for cross-esw scheduling Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 05/11] net/mlx5: DR, Expand SWS STE callbacks and consolidate common structs Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 06/11] net/mlx5: DR, Add support for ConnectX-8 steering Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 07/11] devlink: Extend devlink rate API with traffic classes bandwidth management Tariq Toukan
2024-12-07 2:10 ` Jakub Kicinski
2024-12-09 21:03 ` Tariq Toukan
2024-12-09 21:27 ` Jakub Kicinski
2025-01-20 11:55 ` Carolina Jubran
2025-01-20 18:14 ` Jakub Kicinski
2025-01-21 12:36 ` Carolina Jubran
2025-01-22 12:48 ` Carolina Jubran
2025-01-22 14:30 ` Jakub Kicinski
2025-02-05 6:22 ` Tariq Toukan
2025-02-05 6:56 ` Gal Pressman
2025-02-05 8:02 ` Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 08/11] net/mlx5: Add no-op implementation for setting tc-bw on rate objects Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 09/11] net/mlx5: Add support for setting tc-bw on nodes Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 10/11] net/mlx5: Add traffic class scheduling support for vport QoS Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 11/11] net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw Tariq Toukan
2024-12-05 9:23 ` [PATCH net-next V5 00/11] net/mlx5: ConnectX-8 SW Steering + Rate management on traffic classes Leon Romanovsky
2024-12-07 2:13 ` Jakub Kicinski
2024-12-09 19:32 ` Tariq Toukan [this message]
2024-12-09 21:41 ` Jakub Kicinski
2024-12-11 9:49 ` Cosmin Ratiu
2024-12-12 1:49 ` Jakub Kicinski
2024-12-13 13:42 ` Cosmin Ratiu
2024-12-17 5:45 ` Jakub Kicinski
2024-12-17 15:14 ` Cosmin Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4890336-db2d-49f6-9502-6558cbaccefa@gmail.com \
--to=ttoukan.linux@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leonro@nvidia$(echo .)com \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox