From: Florian Fainelli <f.fainelli@gmail•com>
To: Michael Grzeschik <m.grzeschik@pengutronix•de>, andrew@lunn•ch
Cc: netdev@vger•kernel.org, davem@davemloft•net, kernel@pengutronix•de
Subject: Re: [PATCH v2 2/4] net: tag: ksz: Add KSZ8863 tag code
Date: Wed, 18 Dec 2019 12:13:58 -0800 [thread overview]
Message-ID: <d4f84071-7478-d8a2-bb3e-56ce3b80c306@gmail.com> (raw)
In-Reply-To: <20191218200831.13796-3-m.grzeschik@pengutronix.de>
On 12/18/19 12:08 PM, Michael Grzeschik wrote:
> Add DSA tag code for Microchip KSZ8863 switch.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix•de>
> ---
[snip]
> +/* For ingress (Host -> KSZ8863), 1 byte is added before FCS.
> + * ---------------------------------------------------------------------------
> + * DA(6bytes)|SA(6bytes)|....|Data(nbytes)|tag0(1byte)|tag1(1byte)|FCS(4bytes)
> + * ---------------------------------------------------------------------------
> + * tag0[1,0] : represents port
> + * (e.g. 0b00=addr-lookup 0b01=port1, 0b10=port2, 0b11=port1+port2)
> + * tag0[3,2] : bits two and three represent prioritization
> + * (e.g. 0b00xx=prio0, 0b01xx=prio1, 0b10xx=prio2, 0b11xx=prio3)
> + *
> + * For egress (KSZ8873 -> Host), 1 byte is added before FCS.
> + * ---------------------------------------------------------------------------
> + * DA(6bytes)|SA(6bytes)|....|Data(nbytes)|tag0(1byte)|FCS(4bytes)
> + * ---------------------------------------------------------------------------
> + * tag0[0] : zero-based value represents port
> + * (eg, 0b0=port1, 0b1=port2)
> + */
And another way to define a tag, snowflake after snowflake... anyway:
Reviewed-by: Florian Fainelli <f.fainelli@gmail•com>
--
Florian
next prev parent reply other threads:[~2019-12-18 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 20:08 [PATCH v2 0/4] microchip: add support for ksz88x3 driver family Michael Grzeschik
2019-12-18 20:08 ` [PATCH v2 1/4] micrel: fix config_aneg for ksz886x Michael Grzeschik
2019-12-18 20:11 ` Florian Fainelli
2019-12-18 20:08 ` [PATCH v2 2/4] net: tag: ksz: Add KSZ8863 tag code Michael Grzeschik
2019-12-18 20:13 ` Florian Fainelli [this message]
2019-12-18 20:08 ` [PATCH v2 3/4] ksz: Add Microchip KSZ8863 SMI based driver support Michael Grzeschik
2019-12-18 20:08 ` [PATCH v2 4/4] dt-bindings: net: dsa: document additional Microchip KSZ8863/8873 switch Michael Grzeschik
2019-12-18 23:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4f84071-7478-d8a2-bb3e-56ce3b80c306@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=kernel@pengutronix$(echo .)de \
--cc=m.grzeschik@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox