Subject: RE: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12

From: Ping-Ke Shih <[email-masked]>
Date: Tue, 24 May 2022 00:41:12 +0000

> -----Original Message-----
> From: Jakub Kicinski <[email-masked]>
> Sent: Monday, May 23, 2022 11:57 PM
> To: Ping-Ke Shih <[email-masked]>
> Cc: [email-masked]; [email-masked]; [email-masked]; [email-masked];
> [email-masked]; [email-masked]
> Subject: Re: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12
> 
> On Mon, 23 May 2022 02:35:32 +0000 Ping-Ke Shih wrote:
> > This is a typo since initial commit. Correct it by
> > -			     value[0] != NULL)
> > +			     value[0][0] != 0)
> >
> > So, NACK this patch.
> 
> Too, late, the patches were already applied, sorry. Please post a fixup.

I have sent a patch to correct it: 
https://lore.kernel.org/linux-wireless/[email-masked]/T/#u

Please take it into net-next tree.

Thank you
Ping-Ke