From: Niklas Cassel <niklas.cassel@axis•com>
To: Alexandre Torgue <alexandre.torgue@st•com>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>
Cc: <netdev@vger•kernel.org>
Subject: Re: stmmac DT property snps,axi_all
Date: Fri, 9 Dec 2016 10:20:36 +0100 [thread overview]
Message-ID: <dc145c32-cb67-4bcb-e8b7-059387d5a0ac@axis.com> (raw)
In-Reply-To: <120aca00-02a8-3d88-7aad-a21d239aafb2@st.com>
On 12/08/2016 02:36 PM, Alexandre Torgue wrote:
> Hi Niklas,
>
> On 12/05/2016 05:18 PM, Niklas Cassel wrote:
>> Hello Giuseppe
>>
>>
>> I'm trying to figure out what snps,axi_all is supposed to represent.
>>
>> It appears that the value is saved, but never used in the code.
>>
>> Looking at the register specification, I'm guessing that it represents
>> Address-Aligned Beats, but there is already the property snps,aal
>> for that.
>
> IMO, it is not useful. Indeed AXI_AAL is a read only bit (in AXI bus mode register) and reflects the aal bit in DMA bus register.
> As you know we use "snps,aal" to set aal bit in DMA bus register.
> So "snps,axi_all" entry seems useless. Let's see with Peppe.
Ok, I see. GMAC and GMAC4 is different here.
For GMAC4 AAL only exists in DMA_SYS_BUS_MODE.
It's not reflected anywhere else.
The code is correct in the driver.
If snps,axi_all is just created for a read-only register,
and it is currently never used in the code,
while we have snps,aal, which is correct and works,
I guess it should be ok to remove snps,axi_all.
I can cook up a patch.
>
> Regards
> Alex
>
>>
>>
>> Regards,
>> Niklas
>>
next prev parent reply other threads:[~2016-12-09 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 16:18 stmmac DT property snps,axi_all Niklas Cassel
2016-12-08 13:36 ` Alexandre Torgue
2016-12-09 9:20 ` Niklas Cassel [this message]
2016-12-09 9:53 ` Niklas Cassel
2016-12-09 16:06 ` Alexandre Torgue
2016-12-12 13:16 ` Giuseppe CAVALLARO
2016-12-12 14:18 ` Giuseppe CAVALLARO
2016-12-13 6:47 ` Giuseppe CAVALLARO
2016-12-13 8:26 ` Niklas Cassel
2016-12-13 8:46 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc145c32-cb67-4bcb-e8b7-059387d5a0ac@axis.com \
--to=niklas.cassel@axis$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox