Subject: Re: [PATCH net-next v2 1/2] bnx2x: convert to use ndo_hwtstamp callbacks

From: Vadim Fedorenko <[email-masked]>
Date: Sat, 8 Nov 2025 12:38:25 +0000

On 08/11/2025 02:41, Jakub Kicinski wrote:
> On Thu,  6 Nov 2025 21:37:16 +0000 Vadim Fedorenko wrote:
>> +	switch (config->tx_type) {
>> +	case HWTSTAMP_TX_ONESTEP_SYNC:
>> +	case HWTSTAMP_TX_ONESTEP_P2P:
>> +		NL_SET_ERR_MSG_MOD(extack,
>> +				   "One-step timestamping is not supported");
>> +		return -ERANGE;
>> +	default:
>> +		break;
>> +	}
> 
> This is the wrong way around, if someone adds a new value unsupported
> by the driver it will pass. We should be listing the supported types
> and
> 
> 	default:
> 		...ERR_MSG..
> 		return -ERANGE;
> 	}

But that's the original logic of the driver. Should I change it within
the same patch, or is it better to make a follow-up work to clean such
things in net-next?