public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@fb•com>
To: "Naveen N. Rao" <naveen.n.rao@linux•vnet.ibm.com>,
	<netdev@vger•kernel.org>,
	Sandipan Das <sandipan@linux•vnet.ibm.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail•com>, <daniel@iogearbox•net>,
	Martin KaFai Lau <kafai@fb•com>,
	Kees Cook <keescook@chromium•org>, <linux-kernel@vger•kernel.org>
Subject: Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members
Date: Tue, 7 Nov 2017 17:08:41 +0900	[thread overview]
Message-ID: <df92faa5-ca2b-a623-e074-e14b7345f8e5@fb.com> (raw)
In-Reply-To: <1509982000.092la4257a.naveen@linux.ibm.com>

On 11/7/17 12:55 AM, Naveen N. Rao wrote:
>> I thought such struct shouldn't change layout.
>> If it is we need to fix include/linux/compiler-clang.h to do that
>> anon struct as well.
>
> We considered that, but it looked to be very dependent on the version of
> gcc used to build the kernel. But, this may be a simpler approach for
> the shorter term.
>

why it would depend on version of gcc?
We just need this, no?

diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h
index de179993e039..4e29ab6187cb 100644
--- a/include/linux/compiler-clang.h
+++ b/include/linux/compiler-clang.h
@@ -15,3 +15,6 @@
   * with any version that can compile the kernel
   */
  #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), 
__COUNTER__)
+
+#define randomized_struct_fields_start struct {
+#define randomized_struct_fields_end   };

since offsets are mandated by C standard.

  reply	other threads:[~2017-11-07  8:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03  6:58 [RFC PATCH] bpf: Add helpers to read useful task_struct members Sandipan Das
2017-11-04  9:34 ` Alexei Starovoitov
2017-11-04 17:31   ` Naveen N. Rao
2017-11-04 21:10     ` Alexei Starovoitov
2017-11-06 15:55       ` Naveen N. Rao
2017-11-07  8:08         ` Alexei Starovoitov [this message]
2017-11-07  8:37           ` Naveen N. Rao
2017-11-07 21:14             ` Y Song
2017-11-07 21:31               ` Atish Patra
2017-11-07 21:45                 ` Y Song
2017-11-07 21:39               ` Alexei Starovoitov
2017-11-07 21:47                 ` Y Song
2017-11-07 22:04                   ` Alexei Starovoitov
2017-11-07 22:42                     ` Y Song
2017-11-08  0:29                       ` Atish Patra
2017-11-08  1:25                         ` Y Song
2017-11-06  5:16     ` Sandipan Das
2017-11-07  0:16 ` Tushar Dave

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df92faa5-ca2b-a623-e074-e14b7345f8e5@fb.com \
    --to=ast@fb$(echo .)com \
    --cc=brendan.d.gregg@gmail$(echo .)com \
    --cc=daniel@iogearbox$(echo .)net \
    --cc=kafai@fb$(echo .)com \
    --cc=keescook@chromium$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=sandipan@linux$(echo .)vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox