From: Niklas Schnelle <schnelle@linux•ibm.com>
To: Bjorn Helgaas <helgaas@kernel•org>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Arnd Bergmann <arnd@arndb•de>
Cc: Hans Verkuil <hverkuil-cisco@xs4all•nl>,
Ettore Chimenti <ek5.chimenti@gmail•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Arnd Bergmann <arnd@kernel•org>,
Bjorn Helgaas <bhelgaas@google•com>,
John Garry <john.garry@huawei•com>,
Nick Hu <nickhu@andestech•com>, Greentime Hu <green.hu@gmail•com>,
Vincent Chen <deanbo422@gmail•com>,
Paul Walmsley <paul.walmsley@sifive•com>,
Palmer Dabbelt <palmer@dabbelt•com>,
Albert Ou <aou@eecs•berkeley.edu>, Guo Ren <guoren@kernel•org>,
Damien Le Moal <damien.lemoal@opensource•wdc.com>,
Ian Abbott <abbotti@mev•co.uk>,
H Hartley Sweeten <hsweeten@visionengravers•com>,
Linus Walleij <linus.walleij@linaro•org>,
Bartosz Golaszewski <brgl@bgdev•pl>,
Jean Delvare <jdelvare@suse•com>,
Guenter Roeck <linux@roeck-us•net>,
Dmitry Torokhov <dmitry.torokhov@gmail•com>,
Karsten Keil <isdn@linux-pingi•de>,
Sathya Prakash <sathya.prakash@broadcom•com>,
Sreekanth Reddy <sreekanth.reddy@broadcom•com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom•com>,
Michael Grzeschik <m.grzeschik@pengutronix•de>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Kalle Valo <kvalo@kernel•org>, Jouni Malinen <j@w1•fi>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
Hannes Reinecke <hare@suse•com>,
Kashyap Desai <kashyap.desai@broadcom•com>,
Sumit Saxena <sumit.saxena@broadcom•com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom•com>,
Nilesh Javali <njavali@marvell•com>,
GR-QLogic-Storage-Upstream@marvell•com,
Mark Brown <broonie@kernel•org>,
Sudip Mukherjee <sudipm.mukherjee@gmail•com>,
Teddy Wang <teddy.wang@siliconmotion•com>,
Forest Bond <forest@alittletooquiet•net>,
Jiri Slaby <jirislaby@kernel•org>,
Wim Van Sebroeck <wim@linux-watchdog•org>,
Jaroslav Kysela <perex@perex•cz>, Takashi Iwai <tiwai@suse•com>,
linux-kernel@vger•kernel.org, linux-arch@vger•kernel.org,
linux-pci@vger•kernel.org, linux-riscv@lists•infradead.org,
linux-csky@vger•kernel.org, linux-ide@vger•kernel.org,
linux-gpio@vger•kernel.org, linux-hwmon@vger•kernel.org,
linux-i2c@vger•kernel.org, linux-input@vger•kernel.org,
netdev@vger•kernel.org, linux-media@vger•kernel.org,
MPT-FusionLinux.pdl@broadcom•com, linux-scsi@vger•kernel.org,
intel-wired-lan@lists•osuosl.org, linux-wireless@vger•kernel.org,
megaraidlinux.pdl@broadcom•com, linux-spi@vger•kernel.org,
linux-fbdev@vger•kernel.org, linux-serial@vger•kernel.org,
dri-devel@lists•freedesktop.org, linux-watchdog@vger•kernel.org
Subject: Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI
Date: Wed, 29 Dec 2021 17:55:33 +0100 [thread overview]
Message-ID: <e0877e91d7d50299ea5a3ffcee2cf1016458ce10.camel@linux.ibm.com> (raw)
In-Reply-To: <20211229160317.GA1681139@bhelgaas>
On Wed, 2021-12-29 at 10:03 -0600, Bjorn Helgaas wrote:
> On Wed, Dec 29, 2021 at 01:12:07PM +0100, Mauro Carvalho Chehab wrote:
> > Em Wed, 29 Dec 2021 12:45:38 +0100
> > Niklas Schnelle <schnelle@linux•ibm.com> escreveu:
> > > ...
> > > I do think we agree that once done correctly there is value in
> > > such an option independent of HAS_IOPORT only gating inb() etc uses.
>
> I'm not sure I'm convinced about this. For s390, you could do this
> patch series, where you don't define inb() at all, and you add new
> dependencies to prevent compile errors. Or you could define inb() to
> return ~0, which is what happens on other platforms when the device is
> not present.
>
> > Personally, I don't see much value on a Kconfig var for legacy PCI I/O
> > space. From maintenance PoV, bots won't be triggered if someone use
> > HAS_IOPORT instead of the PCI specific one - or vice-versa. So, we
> > could end having a mix of both at the wrong places, in long term.
> >
> > Also, assuming that PCIe hardware will some day abandon support for
> > "legacy" PCI I/O space, I guess some runtime logic would be needed,
> > in order to work with both kinds of PCIe controllers. So, having a
> > Kconfig option won't help much, IMO.
> >
> > So, my personal preference would be to have just one Kconfig var, but
> > I'm ok if the PCI maintainers decide otherwise.
>
> I don't really like the "LEGACY_PCI" Kconfig option. "Legacy" just
> means something old and out of favor; it doesn't say *what* that
> something is.
>
> I think you're specifically interested in I/O port space usage, and it
> seems that you want all PCI drivers that *only* use I/O port space to
> depend on LEGACY_PCI? Drivers that can use either I/O or memory
> space or both would not depend on LEGACY_PCI? This seems a little
> murky and error-prone.
I'd like to hear Arnd's opinion on this but you're the PCI maintainer
so of course your buy-in would be quite important for such an option.
>
> What if you used the approach from [1] but just dropped the warning?
> The inb() would return ~0 if the platform doesn't support I/O port
> space. Drivers should be prepared to handle that because that's what
> happens if the device doesn't exist.
Hmm, in that mail Linus very clearly and specifically asked for this to
be a compile-time thing. So, if we do want to make it compile-time but
keep the potential errors to a minimum I guess just having HAS_IOPORT
might be valid compromise. It gets caught by bots through allyesconfig
or randconfig on HAS_IOPORT=n architectures. Also it has a nice
symmetry with the existing HAS_IOMEM.
>
>
> HAS_IOPORT and LEGACY_PCI is a lot of Kconfiggery that basically just
> avoids building drivers that aren't useful on s390. I'm not sure the
> benefit outweighs the complication.
>
> Bjorn
>
> [1] https://lore.kernel.org/lkml/CAHk-=wg80je=K7madF4e7WrRNp37e3qh6y10Svhdc7O8SZ_-8g@mail.gmail.com/
>
Despite s390 I believe it would also affect nds32, um, h8300, nios2,
openrisc, hexagon, csky, and xtensa. But yes none of these is any less
niche than us. I do wonder if we will see a new drivers using I/O
ports?
next prev parent reply other threads:[~2021-12-29 16:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211227164317.4146918-1-schnelle@linux.ibm.com>
2021-12-27 16:42 ` [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI Niklas Schnelle
2021-12-27 17:48 ` Guenter Roeck
2021-12-28 2:09 ` Mauro Carvalho Chehab
2021-12-28 8:21 ` Greg Kroah-Hartman
2021-12-28 9:15 ` Mauro Carvalho Chehab
2021-12-28 10:58 ` Niklas Schnelle
2021-12-28 12:01 ` Greg Kroah-Hartman
2021-12-28 12:54 ` Mauro Carvalho Chehab
2021-12-28 15:06 ` Niklas Schnelle
2021-12-28 17:12 ` Mauro Carvalho Chehab
2021-12-29 11:45 ` Niklas Schnelle
2021-12-29 12:12 ` Mauro Carvalho Chehab
2021-12-29 16:03 ` Bjorn Helgaas
2021-12-29 16:55 ` Niklas Schnelle [this message]
2022-01-05 17:42 ` John Garry
2022-01-05 19:47 ` Bjorn Helgaas
2022-01-06 17:41 ` John Garry
2022-01-06 18:14 ` Bjorn Helgaas
2022-01-07 17:16 ` John Garry
2022-01-10 9:34 ` Niklas Schnelle
2021-12-27 16:43 ` [RFC 17/32] net: Kconfig: add HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 17:28 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0877e91d7d50299ea5a3ffcee2cf1016458ce10.camel@linux.ibm.com \
--to=schnelle@linux$(echo .)ibm.com \
--cc=GR-QLogic-Storage-Upstream@marvell$(echo .)com \
--cc=MPT-FusionLinux.pdl@broadcom$(echo .)com \
--cc=abbotti@mev$(echo .)co.uk \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=brgl@bgdev$(echo .)pl \
--cc=broonie@kernel$(echo .)org \
--cc=damien.lemoal@opensource$(echo .)wdc.com \
--cc=davem@davemloft$(echo .)net \
--cc=deanbo422@gmail$(echo .)com \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=ek5.chimenti@gmail$(echo .)com \
--cc=forest@alittletooquiet$(echo .)net \
--cc=green.hu@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=guoren@kernel$(echo .)org \
--cc=hare@suse$(echo .)com \
--cc=helgaas@kernel$(echo .)org \
--cc=hsweeten@visionengravers$(echo .)com \
--cc=hverkuil-cisco@xs4all$(echo .)nl \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=isdn@linux-pingi$(echo .)de \
--cc=j@w1$(echo .)fi \
--cc=jdelvare@suse$(echo .)com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jirislaby@kernel$(echo .)org \
--cc=john.garry@huawei$(echo .)com \
--cc=kashyap.desai@broadcom$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-csky@vger$(echo .)kernel.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=m.grzeschik@pengutronix$(echo .)de \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=megaraidlinux.pdl@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nickhu@andestech$(echo .)com \
--cc=njavali@marvell$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=sathya.prakash@broadcom$(echo .)com \
--cc=shivasharan.srikanteshwara@broadcom$(echo .)com \
--cc=sreekanth.reddy@broadcom$(echo .)com \
--cc=sudipm.mukherjee@gmail$(echo .)com \
--cc=suganath-prabu.subramani@broadcom$(echo .)com \
--cc=sumit.saxena@broadcom$(echo .)com \
--cc=teddy.wang@siliconmotion$(echo .)com \
--cc=tiwai@suse$(echo .)com \
--cc=wim@linux-watchdog$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox