From: Martin KaFai Lau <martin.lau@linux•dev>
To: "D. Wythe" <alibuda@linux•alibaba.com>
Cc: kgraul@linux•ibm.com, wenjia@linux•ibm.com, jaka@linux•ibm.com,
ast@kernel•org, daniel@iogearbox•net, andrii@kernel•org,
pabeni@redhat•com, song@kernel•org, sdf@google•com,
haoluo@google•com, yhs@fb•com, edumazet@google•com,
john.fastabend@gmail•com, kpsingh@kernel•org, jolsa@kernel•org,
guwen@linux•alibaba.com, kuba@kernel•org, davem@davemloft•net,
netdev@vger•kernel.org, linux-s390@vger•kernel.org,
linux-rdma@vger•kernel.org, bpf@vger•kernel.org
Subject: Re: [PATCH bpf-next v3 5/5] bpf/selftests: add selftest for bpf_smc_ops
Date: Thu, 19 Dec 2024 14:59:15 -0800 [thread overview]
Message-ID: <e3bf6bf6-5e81-4b6b-a9cd-40476cff67df@linux.dev> (raw)
In-Reply-To: <20241218024422.23423-6-alibuda@linux.alibaba.com>
On 12/17/24 6:44 PM, D. Wythe wrote:
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include "vmlinux.h"
> +
> +#include <bpf/bpf_helpers.h>
> +#include <bpf/bpf_tracing.h>
> +#include "bpf_tracing_net.h"
> +
> +char _license[] SEC("license") = "GPL";
> +
> +struct smc_sock {
I suspect this should be "smc_sock___local". Otherwise, it can't compile if the
same type is found in vmlinux.h.
I only looked at the high level of prog_tests/test_bpf_smc.c. A few comments,
Try to reuse the helpers in network_helpers.c and test_progs.c, e.g. netns
creation helpers, start_server, ...etc. There are many examples in
selftests/bpf/prog_tests using them.
I see 1s timeout everywhere. BPF CI could be slow some time. Please consider how
reliable the multi-thread test is. If the test is too flaky, it will be put in
the selftests/bpf/DENYLIST.
> + struct sock sk;
> + struct smc_sock *listen_smc;
> + bool use_fallback;
> +} __attribute__((preserve_access_index));
> +
next prev parent reply other threads:[~2024-12-19 22:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 2:44 [PATCH bpf-next v3 0/5] net/smc: Introduce smc_ops D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 1/5] bpf: export necessary sympols for modules with struct_ops D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 2/5] net/smc: Introduce generic hook smc_ops D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 3/5] net/smc: bpf: register smc_ops info struct_ops D. Wythe
2024-12-19 22:48 ` Martin KaFai Lau
2024-12-23 2:00 ` D. Wythe
2024-12-26 19:44 ` Zhu Yanjun
2025-01-03 6:54 ` D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 4/5] libbpf: fix error when st-prefix_ops and ops from differ btf D. Wythe
2024-12-19 22:43 ` Martin KaFai Lau
2024-12-23 2:10 ` D. Wythe
2025-01-07 23:24 ` Martin KaFai Lau
2025-01-08 13:45 ` D. Wythe
2025-01-10 23:38 ` Andrii Nakryiko
2025-01-14 7:11 ` D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 5/5] bpf/selftests: add selftest for bpf_smc_ops D. Wythe
2024-12-19 22:59 ` Martin KaFai Lau [this message]
2024-12-23 2:03 ` D. Wythe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3bf6bf6-5e81-4b6b-a9cd-40476cff67df@linux.dev \
--to=martin.lau@linux$(echo .)dev \
--cc=alibuda@linux$(echo .)alibaba.com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=guwen@linux$(echo .)alibaba.com \
--cc=haoluo@google$(echo .)com \
--cc=jaka@linux$(echo .)ibm.com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kgraul@linux$(echo .)ibm.com \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=song@kernel$(echo .)org \
--cc=wenjia@linux$(echo .)ibm.com \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox