From: Vadim Fedorenko <vadim.fedorenko@linux•dev>
To: Michael Chan <michael.chan@broadcom•com>, davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, andrew+netdev@lunn•ch,
pavan.chebbi@broadcom•com, andrew.gospodarek@broadcom•com,
leon@kernel•org, Srijit Bose <srijit.bose@broadcom•com>,
Ray Jui <ray.jui@broadcom•com>
Subject: Re: [PATCH net v2] bnxt_en: Fix potential data corruption with HW GRO/LRO
Date: Wed, 31 Dec 2025 11:59:55 +0000 [thread overview]
Message-ID: <e491d00f-69bd-4b9a-addb-b60dab971bbe@linux.dev> (raw)
In-Reply-To: <20251231083625.3911652-1-michael.chan@broadcom.com>
On 31/12/2025 08:36, Michael Chan wrote:
> From: Srijit Bose <srijit.bose@broadcom•com>
>
> Fix the max number of bits passed to find_first_zero_bit() in
> bnxt_alloc_agg_idx(). We were incorrectly passing the number of
> long words. find_first_zero_bit() may fail to find a zero bit and
> cause a wrong ID to be used. If the wrong ID is already in use, this
> can cause data corruption. Sometimes an error like this can also be
> seen:
>
> bnxt_en 0000:83:00.0 enp131s0np0: TPA end agg_buf 2 != expected agg_bufs 1
>
> Fix it by passing the correct number of bits MAX_TPA_P5. Use
> DECLARE_BITMAP() to more cleanly define the bitmap. Add a sanity
> check to warn if a bit cannot be found and reset the ring [MChan].
>
> Fixes: ec4d8e7cf024 ("bnxt_en: Add TPA ID mapping logic for 57500 chips.")
> Reviewed-by: Ray Jui <ray.jui@broadcom•com>
> Signed-off-by: Srijit Bose <srijit.bose@broadcom•com>
> Signed-off-by: Michael Chan <michael.chan@broadcom•com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux•dev>
next prev parent reply other threads:[~2025-12-31 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 8:36 [PATCH net v2] bnxt_en: Fix potential data corruption with HW GRO/LRO Michael Chan
2025-12-31 11:59 ` Vadim Fedorenko [this message]
2026-01-04 19:12 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e491d00f-69bd-4b9a-addb-b60dab971bbe@linux.dev \
--to=vadim.fedorenko@linux$(echo .)dev \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew.gospodarek@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=ray.jui@broadcom$(echo .)com \
--cc=srijit.bose@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox