Subject: RE: [PATCH V2] rtw89: fix error function parameter

From: Pkshih <[email-masked]>
Date: Thu, 21 Oct 2021 05:22:14 +0000

> -----Original Message-----
> From: [email-masked] <[email-masked]>
> Sent: Thursday, October 21, 2021 12:21 PM
> To: Pkshih <[email-masked]>
> Cc: [email-masked]; [email-masked]; [email-masked]; [email-masked];
> [email-masked]; [email-masked]; Lv Ruyi <[email-masked]>; Zeal Robot
> <[email-masked]>
> Subject: [PATCH V2] rtw89: fix error function parameter
> 
> From: Lv Ruyi <[email-masked]>
> 
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING  possible condition with no effect (if == else)
> 
> Reported-by: Zeal Robot <[email-masked]>
> Signed-off-by: Lv Ruyi <[email-masked]>

Acked-by: Ping-Ke Shih <[email-masked]>

I think you can say something about the changes of v2 followed by '---', like

---
v2: fix tabs are converted to spaces

> ---
>  drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> index b1b87f0aadbb..5c6ffca3a324 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> @@ -757,7 +757,7 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
>  		else
  ^^^^^^
I have confirmed this is a tab.

>  			rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
>  					      B_P1_MODE_SEL,
> -					      1, phy_idx);
> +					      0, phy_idx);
>  		/* SCO compensate FC setting */
>  		sco_comp = rtw8852a_sco_mapping(central_ch);
>  		rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
> --
> 2.25.1