From: David Ahern <dsahern@gmail•com>
To: Phil Sutter <phil@nwl•cc>, David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [net-next PATCH] net: rtnetlink: Enslave device before bringing it up
Date: Wed, 29 May 2019 09:41:07 -0600 [thread overview]
Message-ID: <e684c23a-93cc-d424-e217-e6ac2a371029@gmail.com> (raw)
In-Reply-To: <20190529135120.32241-1-phil@nwl.cc>
On 5/29/19 7:51 AM, Phil Sutter wrote:
> Unlike with bridges, one can't add an interface to a bond and set it up
> at the same time:
>
> | # ip link set dummy0 down
> | # ip link set dummy0 master bond0 up
> | Error: Device can not be enslaved while up.
>
> Of all drivers with ndo_add_slave callback, bond and team decline if
> IFF_UP flag is set, vrf cycles the interface (i.e., sets it down and
> immediately up again) and the others just don't care.
>
> Support the common notion of setting the interface up after enslaving it
> by sorting the operations accordingly.
>
> Signed-off-by: Phil Sutter <phil@nwl•cc>
> ---
> net/core/rtnetlink.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
I agree with the intent - enslave before up.
Not sure how likely this is, but it does break the case:
ip li set dummy0 master bond0 down
next prev parent reply other threads:[~2019-05-29 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 13:51 [net-next PATCH] net: rtnetlink: Enslave device before bringing it up Phil Sutter
2019-05-29 15:41 ` David Ahern [this message]
2019-05-29 17:21 ` Phil Sutter
2019-05-31 21:26 ` David Miller
2019-06-02 10:33 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e684c23a-93cc-d424-e217-e6ac2a371029@gmail.com \
--to=dsahern@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=phil@nwl$(echo .)cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox