From: Jesper Dangaard Brouer <hawk@kernel•org>
To: Alexander Lobakin <aleksander.lobakin@intel•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>
Cc: Maciej Fijalkowski <maciej.fijalkowski@intel•com>,
Larysa Zaremba <larysa.zaremba@intel•com>,
Yunsheng Lin <linyunsheng@huawei•com>,
Alexander Duyck <alexanderduyck@fb•com>,
Jesper Dangaard Brouer <hawk@kernel•org>,
Ilias Apalodimas <ilias.apalodimas@linaro•org>,
Simon Horman <simon.horman@corigine•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next v3 5/6] page_pool: add a lockdep check for recycling in hardirq
Date: Fri, 4 Aug 2023 12:30:52 +0200 [thread overview]
Message-ID: <e9196324-e228-d160-4c8f-ae45b4773633@kernel.org> (raw)
In-Reply-To: <20230803182038.2646541-6-aleksander.lobakin@intel.com>
On 03/08/2023 20.20, Alexander Lobakin wrote:
> From: Jakub Kicinski<kuba@kernel•org>
>
> Page pool use in hardirq is prohibited, add debug checks
> to catch misuses. IIRC we previously discussed using
> DEBUG_NET_WARN_ON_ONCE() for this, but there were concerns
> that people will have DEBUG_NET enabled in perf testing.
> I don't think anyone enables lockdep in perf testing,
> so use lockdep to avoid pushback and arguing :)
>
> Signed-off-by: Jakub Kicinski<kuba@kernel•org>
> Signed-off-by: Alexander Lobakin<aleksander.lobakin@intel•com>
I like this.
Acked-by: Jesper Dangaard Brouer <hawk@kernel•org>
next prev parent reply other threads:[~2023-08-04 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 18:20 [PATCH net-next v3 0/6] page_pool: a couple of assorted optimizations Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 1/6] page_pool: split types and declarations from page_pool.h Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 2/6] net: skbuff: don't include <net/page_pool/types.h> to <linux/skbuff.h> Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 3/6] page_pool: place frag_* fields in one cacheline Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 4/6] net: skbuff: avoid accessing page_pool if !napi_safe when returning page Alexander Lobakin
2023-08-03 18:20 ` [PATCH net-next v3 5/6] page_pool: add a lockdep check for recycling in hardirq Alexander Lobakin
2023-08-04 10:30 ` Jesper Dangaard Brouer [this message]
2023-08-03 18:20 ` [PATCH net-next v3 6/6] net: skbuff: always try to recycle PP pages directly when in softirq Alexander Lobakin
2023-08-04 1:21 ` [PATCH net-next v3 0/6] page_pool: a couple of assorted optimizations Jakub Kicinski
2023-08-04 14:31 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9196324-e228-d160-4c8f-ae45b4773633@kernel.org \
--to=hawk@kernel$(echo .)org \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=alexanderduyck@fb$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=larysa.zaremba@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linyunsheng@huawei$(echo .)com \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox