Subject: Re: [PATCH] forcedeth: jumbo frame support

From: Tim Mattox <[email-masked]>
Date: Sat, 16 Jul 2005 17:09:09 -0400

This is just from a simple read of Manfred's patch, but shouldn't one side of
the if-else use the NV_PKTLIMIT_2 value?  If not, why is
np->pkt_limit = NV_PKTLIMIT_1; inside the if-else at all?

On 7/16/05, Manfred Spraul <[email-masked]> wrote:
[snip]
> +/* maximum mtu size */
> +#define NV_PKTLIMIT_1  ETH_DATA_LEN    /* hard limit not known */
> +#define NV_PKTLIMIT_2  9100    /* Actual limit according to NVidia: 9202 */
[snip]
> @@ -2007,13 +2093,16 @@
> 
>         /* handle different descriptor versions */
>         if (pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_1 ||
> -               pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_2 ||
> -               pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_3 ||
> -               pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_12 ||
> -               pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_13)
> +                       pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_2 ||
> +                       pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_3 ||
> +                       pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_12 ||
> +                       pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_13) {
>                 np->desc_ver = DESC_VER_1;
> -       else
> +               np->pkt_limit = NV_PKTLIMIT_1;
> +       } else {
>                 np->desc_ver = DESC_VER_2;
> +               np->pkt_limit = NV_PKTLIMIT_1;
> +       }

-- 
Tim Mattox - [email-masked]
  http://homepage.mac.com/tmattox/
    I'm a bright... http://www.the-brights.net/